Skip to content

stm32cube: dfsdm: fix HAL_DFSDM_IRQHandler #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgallaispou wants to merge 2 commits into
base: main
Choose a base branch
from
Open

stm32cube: dfsdm: fix HAL_DFSDM_IRQHandler #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4394759
Fix DFSDM IRQHandler in every platforms
rgallaispouSTM Mar 30, 2026
1ec9325
stm32cube: stm32f4/f7/h7/l4/l5/mp13/mp1: Document patch in README
rgallaispouSTM Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions stm32cube/stm32f4xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,4 +60,13 @@ Patch List:
Impacted files:
drivers/include/stm32f4xx_ll_fsmc.h
ST Internal Reference: 223859

*Fix HAL_DFSDM_IRQHandler
HAL_DFSDM_IRQHandler handles IRQ flags in an if {} else if {} condition.
This causes interrupts to be handled once and only the first flag
encountered in the condition, while there can be several flags raised.
Impacted files:
drivers/src/stm32f7xx_hal_dfsdm.c
ST Internal Reference: HAL1-27454

See release_note.html from STM32Cube
16 changes: 8 additions & 8 deletions stm32cube/stm32f4xx/drivers/src/stm32f4xx_hal_dfsdm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3334,7 +3334,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if overrun occurs during injected conversion */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JOVRF) != 0U) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JOVRF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_JOVRIE) != 0U))
{
/* Clear injected overrun flag */
Expand All @@ -3351,7 +3351,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if end of regular conversion */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_REOCF) != 0U) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_REOCF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_REOCIE) != 0U))
{
/* Call regular conversion complete callback */
Expand All @@ -3374,7 +3374,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if end of injected conversion */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JEOCF) != 0U) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JEOCF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_JEOCIE) != 0U))
{
/* Call injected conversion complete callback */
Expand Down Expand Up @@ -3404,7 +3404,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if analog watchdog occurs */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_AWDF) != 0U) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_AWDF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_AWDIE) != 0U))
{
uint32_t reg = 0U;
Expand Down Expand Up @@ -3436,7 +3436,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if clock absence occurs */
else if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_CKABF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_CKABIE) != 0U))
{
Expand Down Expand Up @@ -3470,7 +3470,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
#if defined (DFSDM2_Channel0)
/* Check if clock absence occurs */
else if((hdfsdm_filter->Instance == DFSDM2_Filter0) && \
if((hdfsdm_filter->Instance == DFSDM2_Filter0) && \
((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_CKABF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_CKABIE) != 0U))
{
Expand Down Expand Up @@ -3504,7 +3504,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
#endif /* DFSDM2_Channel0 */
/* Check if short circuit detection occurs */
else if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_SCDF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_SCDIE) != 0U))
{
Expand All @@ -3531,7 +3531,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
#if defined (DFSDM2_Channel0)
/* Check if short circuit detection occurs */
else if((hdfsdm_filter->Instance == DFSDM2_Filter0) && \
if((hdfsdm_filter->Instance == DFSDM2_Filter0) && \
((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_SCDF) != 0U) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_SCDIE) != 0U))
{
Expand Down
8 changes: 8 additions & 0 deletions stm32cube/stm32f7xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,12 @@ Patch List:
Impacted files:
drivers/include/Legacy/stm32_hal_legacy.h

*Fix HAL_DFSDM_IRQHandler
HAL_DFSDM_IRQHandler handles IRQ flags in an if {} else if {} condition.
This causes interrupts to be handled once and only the first flag
encountered in the condition, while there can be several flags raised.
Impacted files:
drivers/src/stm32f7xx_hal_dfsdm.c
ST Internal Reference: HAL1-27454

See release_note.html from STM32Cube
12 changes: 6 additions & 6 deletions stm32cube/stm32f7xx/drivers/src/stm32f7xx_hal_dfsdm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2897,7 +2897,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if overrun occurs during injected conversion */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JOVRF) != 0) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JOVRF) != 0) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_JOVRIE) != 0))
{
/* Clear injected overrun flag */
Expand All @@ -2914,7 +2914,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if end of regular conversion */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_REOCF) != 0) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_REOCF) != 0) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_REOCIE) != 0))
{
/* Call regular conversion complete callback */
Expand All @@ -2937,7 +2937,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if end of injected conversion */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JEOCF) != 0) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_JEOCF) != 0) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_JEOCIE) != 0))
{
/* Call injected conversion complete callback */
Expand Down Expand Up @@ -2967,7 +2967,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if analog watchdog occurs */
else if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_AWDF) != 0) && \
if(((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_AWDF) != 0) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_AWDIE) != 0))
{
uint32_t reg = 0;
Expand Down Expand Up @@ -2999,7 +2999,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if clock absence occurs */
else if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_CKABF) != 0) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_CKABIE) != 0))
{
Expand Down Expand Up @@ -3032,7 +3032,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if short circuit detection occurs */
else if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((hdfsdm_filter->Instance->FLTISR & DFSDM_FLTISR_SCDF) != 0) && \
((hdfsdm_filter->Instance->FLTCR2 & DFSDM_FLTCR2_SCDIE) != 0))
{
Expand Down
8 changes: 8 additions & 0 deletions stm32cube/stm32h7xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,4 +80,12 @@ Patch List:
Impacted files:
stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_ospi.c

*Fix HAL_DFSDM_IRQHandler
HAL_DFSDM_IRQHandler handles IRQ flags in an if {} else if {} condition.
This causes interrupts to be handled once and only the first flag
encountered in the condition, while there can be several flags raised.
Impacted files:
drivers/src/stm32f7xx_hal_dfsdm.c
ST Internal Reference: HAL1-27454

See release_note.html from STM32Cube
12 changes: 6 additions & 6 deletions stm32cube/stm32h7xx/drivers/src/stm32h7xx_hal_dfsdm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3129,7 +3129,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if overrun occurs during injected conversion */
else if(((temp_fltisr & DFSDM_FLTISR_JOVRF) != 0U) && \
if(((temp_fltisr & DFSDM_FLTISR_JOVRF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_JOVRIE) != 0U))
{
/* Clear injected overrun flag */
Expand All @@ -3146,7 +3146,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if end of regular conversion */
else if(((temp_fltisr & DFSDM_FLTISR_REOCF) != 0U) && \
if(((temp_fltisr & DFSDM_FLTISR_REOCF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_REOCIE) != 0U))
{
/* Call regular conversion complete callback */
Expand All @@ -3169,7 +3169,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if end of injected conversion */
else if(((temp_fltisr & DFSDM_FLTISR_JEOCF) != 0U) && \
if(((temp_fltisr & DFSDM_FLTISR_JEOCF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_JEOCIE) != 0U))
{
/* Call injected conversion complete callback */
Expand Down Expand Up @@ -3199,7 +3199,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if analog watchdog occurs */
else if(((temp_fltisr & DFSDM_FLTISR_AWDF) != 0U) && \
if(((temp_fltisr & DFSDM_FLTISR_AWDF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_AWDIE) != 0U))
{
uint32_t reg;
Expand Down Expand Up @@ -3231,7 +3231,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if clock absence occurs */
else if((hdfsdm_filter->Instance == filter0Instance) && \
if((hdfsdm_filter->Instance == filter0Instance) && \
((temp_fltisr & DFSDM_FLTISR_CKABF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_CKABIE) != 0U))
{
Expand Down Expand Up @@ -3264,7 +3264,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if short circuit detection occurs */
else if((hdfsdm_filter->Instance == filter0Instance) && \
if((hdfsdm_filter->Instance == filter0Instance) && \
((temp_fltisr & DFSDM_FLTISR_SCDF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_SCDIE) != 0U))
{
Expand Down
8 changes: 8 additions & 0 deletions stm32cube/stm32l4xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,12 @@ Patch List:
Impacted files:
drivers/include/Legacy/stm32_hal_legacy.h

*Fix HAL_DFSDM_IRQHandler
HAL_DFSDM_IRQHandler handles IRQ flags in an if {} else if {} condition.
This causes interrupts to be handled once and only the first flag
encountered in the condition, while there can be several flags raised.
Impacted files:
drivers/src/stm32f7xx_hal_dfsdm.c
ST Internal Reference: HAL1-27454

See release_note.html from STM32Cube
12 changes: 6 additions & 6 deletions stm32cube/stm32l4xx/drivers/src/stm32l4xx_hal_dfsdm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2913,7 +2913,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if overrun occurs during injected conversion */
else if (((temp_fltisr & DFSDM_FLTISR_JOVRF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_JOVRF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_JOVRIE) != 0U))
{
/* Clear injected overrun flag */
Expand All @@ -2930,7 +2930,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if end of regular conversion */
else if (((temp_fltisr & DFSDM_FLTISR_REOCF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_REOCF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_REOCIE) != 0U))
{
/* Call regular conversion complete callback */
Expand All @@ -2953,7 +2953,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if end of injected conversion */
else if (((temp_fltisr & DFSDM_FLTISR_JEOCF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_JEOCF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_JEOCIE) != 0U))
{
/* Call injected conversion complete callback */
Expand Down Expand Up @@ -2983,7 +2983,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if analog watchdog occurs */
else if (((temp_fltisr & DFSDM_FLTISR_AWDF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_AWDF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_AWDIE) != 0U))
{
uint32_t reg;
Expand Down Expand Up @@ -3015,7 +3015,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if clock absence occurs */
else if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((temp_fltisr & DFSDM_FLTISR_CKABF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_CKABIE) != 0U))
{
Expand Down Expand Up @@ -3048,7 +3048,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if short circuit detection occurs */
else if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((temp_fltisr & DFSDM_FLTISR_SCDF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_SCDIE) != 0U))
{
Expand Down
8 changes: 8 additions & 0 deletions stm32cube/stm32l5xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,12 @@ Patch List:
Impacted files:
drivers/include/Legacy/stm32_hal_legacy.h

*Fix HAL_DFSDM_IRQHandler
HAL_DFSDM_IRQHandler handles IRQ flags in an if {} else if {} condition.
This causes interrupts to be handled once and only the first flag
encountered in the condition, while there can be several flags raised.
Impacted files:
drivers/src/stm32f7xx_hal_dfsdm.c
ST Internal Reference: HAL1-27454

See release_note.html from STM32Cube
12 changes: 6 additions & 6 deletions stm32cube/stm32l5xx/drivers/src/stm32l5xx_hal_dfsdm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2901,7 +2901,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if overrun occurs during injected conversion */
else if (((temp_fltisr & DFSDM_FLTISR_JOVRF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_JOVRF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_JOVRIE) != 0U))
{
/* Clear injected overrun flag */
Expand All @@ -2918,7 +2918,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if end of regular conversion */
else if (((temp_fltisr & DFSDM_FLTISR_REOCF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_REOCF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_REOCIE) != 0U))
{
/* Call regular conversion complete callback */
Expand All @@ -2941,7 +2941,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if end of injected conversion */
else if (((temp_fltisr & DFSDM_FLTISR_JEOCF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_JEOCF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_JEOCIE) != 0U))
{
/* Call injected conversion complete callback */
Expand Down Expand Up @@ -2971,7 +2971,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if analog watchdog occurs */
else if (((temp_fltisr & DFSDM_FLTISR_AWDF) != 0U) && \
if (((temp_fltisr & DFSDM_FLTISR_AWDF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_AWDIE) != 0U))
{
uint32_t reg;
Expand Down Expand Up @@ -3003,7 +3003,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
#endif
}
/* Check if clock absence occurs */
else if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((temp_fltisr & DFSDM_FLTISR_CKABF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_CKABIE) != 0U))
{
Expand Down Expand Up @@ -3036,7 +3036,7 @@ void HAL_DFSDM_IRQHandler(DFSDM_Filter_HandleTypeDef *hdfsdm_filter)
}
}
/* Check if short circuit detection occurs */
else if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
if ((hdfsdm_filter->Instance == DFSDM1_Filter0) && \
((temp_fltisr & DFSDM_FLTISR_SCDF) != 0U) && \
((temp_fltcr2 & DFSDM_FLTCR2_SCDIE) != 0U))
{
Expand Down
8 changes: 8 additions & 0 deletions stm32cube/stm32mp13xx/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,12 @@ Patch List:
stm32cube/stm32mp13xx/drivers/include/stm32mp13xx_hal_eth.h
Internal reference: 219972

*Fix HAL_DFSDM_IRQHandler
HAL_DFSDM_IRQHandler handles IRQ flags in an if {} else if {} condition.
This causes interrupts to be handled once and only the first flag
encountered in the condition, while there can be several flags raised.
Impacted files:
drivers/src/stm32mp13xx_hal_dfsdm.c
ST Internal Reference: HAL1-27454

See release_note.html from STM32Cube
Loading