Soft HPQM and Rx buffer programming support #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajayparida
requested review from
jukkar,
krish2718,
rado17,
rajb9 and
sachinthegreen
as code owners
rajb9
approved these changes
May 26, 2025
This was referenced May 26, 2025
sachinthegreen
requested changes
May 29, 2025
Comment on lines
144
to
145
| #define NRF_WIFI_HOST_RPU_GDRAM_START_ADDR 0x20084548 | ||
| #define NRF_WIFI_HOST_RPU_TX_CMD_START_ADDR 0x200800b8 |
Collaborator
There was a problem hiding this comment.
These be part of rpu_if.h ?
Makefile
Outdated
| ccflags-y += -DNRF_WIFI_DISPLAY_SCAN_BSS_LIMIT=150 | ||
| ccflags-y += -DNRF_WIFI_RPU_MIN_TIME_TO_ENTER_SLEEP_MS=1000 | ||
| ccflags-y += -DWIFI_NRF70_LOG_LEVEL=1 | ||
| #ccflags-y += -DNRF71_RX_BUFF |
Collaborator
There was a problem hiding this comment.
This should be part of Kconfig ? Also needs a more representative name (Just NRF71_RX_BUFF doesn't give an indication of what this feature is about).
sachinthegreen
requested changes
May 29, 2025
ajayparida
force-pushed
the
combo_rx_buff_soft_hpqm
branch
from
f8912ca to
63f92f6
Compare
In nRF70, the host programmed RX buffers directly to the RPU through hardware queues. With nRF71, hardware queues are not accessible from the host side. This update adds a command handling to allow the host to pass RX buffers to UMAC firmware, which then programs them to the RPU. Signed-off-by: Ajay Parida <[email protected]>
SOFT_HPQM is to replace existing hardware based queue used to communicate between host and firmware. Targeted towards nrf71 based system. TX and CTRL commands are used to communicate using software queue. RX buffers are programmed to firmware at initialization are handled by firmware. Signed-off-by: Ajay Parida <[email protected]>
ajayparida
force-pushed
the
combo_rx_buff_soft_hpqm
branch
from
63f92f6 to
36b86fc
Compare
sachinthegreen
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soft HPQM and Rx host buffer programming support.