Skip to content

nrf71: Fixes during testing #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2025
Merged

nrf71: Fixes during testing #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb998b9
Fix build
krish2718 Oct 13, 2025
17a54fd
Initailize the max command and event sizes
krish2718 Oct 13, 2025
f6d0977
Fix build warnings
krish2718 Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@ target_sources(nrf-wifi-osal PRIVATE
${NRF_WIFI_DIR}/utils/src/util.c
${NRF_WIFI_DIR}/hw_if/hal/src/common/hal_api_common.c
${NRF_WIFI_DIR}/bus_if/bal/src/bal.c
${NRF_WIFI_DIR}/bus_if/bus/qspi/src/qspi.c
${NRF_WIFI_DIR}/fw_if/umac_if/src/common/fmac_cmd_common.c
${NRF_WIFI_DIR}/fw_if/umac_if/src/common/fmac_api_common.c
${NRF_WIFI_DIR}/fw_if/umac_if/src/common/fmac_util.c
Expand All @@ -187,7 +188,6 @@ if(NOT CONFIG_NRF71_ON_IPC)
${NRF_WIFI_DIR}/hw_if/hal/src/common/hpqm.c
${NRF_WIFI_DIR}/hw_if/hal/src/common/pal.c
${NRF_WIFI_DIR}/hw_if/hal/src/common/hal_fw_patch_loader.c
${NRF_WIFI_DIR}/bus_if/bus/qspi/src/qspi.c
)
endif()

Expand Down
1 change: 1 addition & 0 deletions bus_if/bus/qspi/src/qspi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

#include "bal_structs.h"
#include "qspi.h"
#include "osal_api.h"
#ifndef NRF71_ON_IPC
#include "common/pal.h"
#endif
Expand Down
2 changes: 1 addition & 1 deletion fw_if/umac_if/src/common/fmac_cmd_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@
* FMAC IF Layer of the Wi-Fi driver.
*/

#include "common/hal_api_common.h"

#ifdef NRF71_ON_IPC
#include <nrf71_wifi_ctrl.h>
#else
#include "host_rpu_umac_if.h"
#include "common/hal_api_common.h"
#endif
#include "common/fmac_structs_common.h"
#include "common/fmac_util.h"
Expand Down
2 changes: 2 additions & 0 deletions fw_if/umac_if/src/radio_test/fmac_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ struct nrf_wifi_fmac_priv *nrf_wifi_rt_fmac_init(void)


hal_cfg_params.max_cmd_size = MAX_NRF_WIFI_UMAC_CMD_SIZE;
#ifndef NRF71_ON_IPC
hal_cfg_params.max_event_size = MAX_EVENT_POOL_LEN;
#endif /* !NRF71_ON_IPC */

fpriv->hpriv = nrf_wifi_hal_init(&hal_cfg_params,
&nrf_wifi_rt_fmac_event_callback,
Expand Down
5 changes: 3 additions & 2 deletions fw_if/umac_if/src/system/fmac_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,11 +658,12 @@ struct nrf_wifi_fmac_priv *nrf_wifi_sys_fmac_init(struct nrf_wifi_data_config_pa
hal_cfg_params.max_tx_frm_sz = NRF_WIFI_IFACE_MTU + NRF_WIFI_FMAC_ETH_HDR_LEN +
TX_BUF_HEADROOM;

#ifndef NRF71_ON_IPC
hal_cfg_params.max_cmd_size = MAX_NRF_WIFI_UMAC_CMD_SIZE;
hal_cfg_params.max_event_size = MAX_EVENT_POOL_LEN;
#ifndef NRF71_ON_IPC
hal_cfg_params.max_event_size = MAX_EVENT_POOL_LEN;;
#endif /* !NRF71_ON_IPC */


fpriv->hpriv = nrf_wifi_hal_init(&hal_cfg_params,
&nrf_wifi_sys_fmac_event_callback,
#ifdef NRF_WIFI_RPU_RECOVERY
Expand Down
2 changes: 2 additions & 0 deletions hw_if/hal/inc/common/hal_api_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@

#include "bal_api.h"
#include "hal_structs_common.h"
#ifndef NRF71_ON_IPC
#include "hal_mem.h"
#include "hal_reg.h"
#include "hal_fw_patch_loader.h"
#endif /* !NRF71_ON_IPC */

#define NRF_WIFI_ADDR_REG_NAME_LEN 16

Expand Down
5 changes: 3 additions & 2 deletions hw_if/hal/src/common/hal_api_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@
*/

#include "queue.h"
#include "common/hal_structs_common.h"

#include "common/hal_api_common.h"
#ifndef NRF71_ON_IPC
#include "common/hal_common.h"
#include "common/hal_reg.h"
#include "common/hal_mem.h"
#ifndef NRF71_ON_IPC
#include "common/hal_interrupt.h"
#include "common/pal.h"
#endif /* !NRF71_ON_IPC */
Expand Down