repo: Patch coverage with subprocess#840
Conversation
Coverage subprocess has been removed in pytest-cov 7.0. To migrate the `patch` option has to be added. See https://pytest-cov.readthedocs.io/en/latest/subprocess-support.html Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #840 +/- ##
===========================================
+ Coverage 47.86% 84.43% +36.57%
===========================================
Files 11 11
Lines 3366 3366
===========================================
+ Hits 1611 2842 +1231
+ Misses 1755 524 -1231 🚀 New features to boost your workflow:
|
I lost track of the previous discussion sorry (assuming I ever was on top of it...EDIT: #802?) but why can't this simply be solved with TWO
If that's any consolation, someone would have had to spend this time eventually anyway and it most likely would have still been you :-/ However I agree it would be better to be in control of the timing! |
Coverage subprocess has been removed in pytest-cov 7.0. To migrate the
patchoption has to be added.See https://pytest-cov.readthedocs.io/en/latest/subprocess-support.html
@marc-hb the coverage plummeted to 48% for no apparent reason because, in CI, we simply install the latest versions of all tools.
As it took quite some time to figure this out, I intend to come back to locking dependency versions in CI. But with a better proposal, stay tuned.