Add test coverage for special characters in manifest and west commands#928
Add test coverage for special characters in manifest and west commands#928pdgendt merged 4 commits intozephyrproject-rtos:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
marc-hb
force-pushed
the
backslash-tests
branch
2 times, most recently
from
7b254a9 to
b30eff3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 85.95% 86.06% +0.11%
==========================================
Files 11 11
Lines 3454 3460 +6
==========================================
+ Hits 2969 2978 +9
+ Misses 485 482 -3 |
This comment was marked as resolved.
This comment was marked as resolved.
Minor whitespace changes to get closer with the default yaml.dump() and west manifest --resolve output formats. This does not reduce diffs entirely to zero but it does considerably and makes them readable. Zero functional change. Signed-off-by: Marc Herbert <Marc.Herbert@gmail.com>
This makes on-the-fly changes to test configurations more convenient. Signed-off-by: Marc Herbert <Marc.Herbert@gmail.com>
Detect any unexpected changes in the way we've been handling backslashes and multiple slashes in paths. Changes in how we handle such edge cases may or may not be desired (and this test may be updated accordingly), but we never want these changes to come as a surprise and we want to keep control over them. This came up as part of the review for zephyrproject-rtos#920 which fixes zephyrproject-rtos#725 Signed-off-by: Marc Herbert <Marc.Herbert@gmail.com>
Add some test coverage for forward and backslashes + whitespace in filenames for west extensions Spurred by a discussion in the review of zephyrproject-rtos#920 which fixes zephyrproject-rtos#725 Signed-off-by: Marc Herbert <Marc.Herbert@gmail.com>
|
@nmunnich PTAL |
|
Code changes look fine to me. Did you want this specially tested on Windows natively? |
|
Thx @nmunnich for your time, much appreciated. I tested this thoroughly with WINE (see #923) and based on other WINE experience I'm pretty confident it does catch Windows-specific paths issues. Also, GitHub CI runs Windows. All this being said, it would be even better if you could spent 3 more minutes running these tests on Window cause you can never have too much coverage! You can only waste time and/or resources testing the wrong priorities but this one should be really quick. Up to you. Also, if it looks OK then please feel free to hit the "Approve" button :-) |
|
Note to self: this #928 does not involve any |
3 participants
Pure tests changes.
Prompted by the #920 fix.
cc: @nmunnich