check manifest --resolve in _subdir_special_chars() test#962
Conversation
Also rename it from ..._windows_paths() to ..._special_chars() for consistency with existing tests. Signed-off-by: Marc Herbert <marc.herbert@gmail.com>
This is useful for other tests. Signed-off-by: Marc Herbert <marc.herbert@gmail.com>
Extend test that was just added by commit 1152ac2 ("tests: extension-commands: Add test checking \\ windows-style variants for west-commands") This exposes new issue zephyrproject-rtos#961 where the behavior is not consistent, not even on Windows alone. Signed-off-by: Marc Herbert <marc.herbert@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #962 +/- ##
==========================================
+ Coverage 86.21% 86.24% +0.02%
==========================================
Files 11 11
Lines 3504 3504
==========================================
+ Hits 3021 3022 +1
+ Misses 483 482 -1 |
|
@nmunnich PTAL |
| # FIXME #961: this is inconsistent with the other _special_chars() test | ||
| # below which does NOT normalize as_posix() on Windows! |
There was a problem hiding this comment.
I wasn't sure if this FIXME was intended to be fixed in this PR.
There was a problem hiding this comment.
No, this PR is purely about adding tests that record the existing behavior. This FIXME is only here to make sure a test failure here is not confusing someone working on #961! Such work could/should make this test fail.
|
I was too slow, sorry! Planned to look tomorrow. |
Feedback still welcome, also here: #966 EDIT: oops different contributor |
No, I was too impatient :-)
Thank you! Please comment like this was not merged yet. |
3 participants
3 commits. Main one:
Extend test that was just added by commit 1152ac2 ("tests: extension-commands: Add test checking \ windows-style variants for west-commands")
This exposes new issue #961 where the behavior is not consistent, not even on Windows alone.
Signed-off-by: Marc Herbert marc.herbert@gmail.com