Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cortex R52 and Rust library support #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthewjrichey
Copy link

In this pull request I have added:

  • support for building Rust for Cortex-R52 cores using the armv8r-none-eabihf target
  • support for building Rust libraries into C applications

This commit adds Rust build support for the Cortex-R52 CPU type.

Signed-off-by: Matthew Richey <[email protected]>
This commit adds a new cmake function rust_cargo_library() to build a
Rust staticlib library with cbindgen-generated header file, which can be
linked into a C application.

Signed-off-by: Matthew Richey <[email protected]>
@d3zd3z
Copy link
Collaborator

d3zd3z commented Feb 24, 2025

Sorry I haven't gotten around to reviewing this until now. Both of these seem quite reasonable, although I don't have a way to directly test. Is there a cortex-R target in Zephyr we can use to do a build test in CI?

@d3zd3z
Copy link
Collaborator

d3zd3z commented Feb 24, 2025

Don't worry about the Doc preview. I need to work with Zephyr ops to figure out how to get PRs from clones to have the credentials.

@matthewjrichey
Copy link
Author

Thank you for reviewing.

There are Zephyr Cortex R targets, but I'm not sure about what CI resources are available to run Cortex R builds. Also I do not know much about how the Zephyr project automates its testing or what CI-related requirements they specify for public code submissions. I am sure this is documented somewhere, I'll need to look for it.

Generally, as far as you know, do all repos in the zephyrproject-rtos github organization (or, does zephyr-lang-rust in particular) follow the same guidelines with respect to CI requirements?

@nashif
Copy link
Member

nashif commented Feb 25, 2025

There are Zephyr Cortex R targets, but I'm not sure about what CI resources are available to run Cortex R builds.

*** Booting Zephyr OS build v4.1.0-rc2-9-g3e75ce132ddf ***
Hello World! qemu_cortex_r5/zynqmp_rpu

:)

@matthewjrichey
Copy link
Author

Hi everyone. What can I do to build some more traction on this PR? Discussion so far has been about CI, are we stalled here? What exactly needs to be done on the CI front to move this forward?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants