modem: backend: tty: Support building with any C library #101355
+58
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Modem
area: Tests
Ensure we call into the host C library open/close/read/write independently of which embedded C library the code is built with. We do this by: a) Using the native simulator nsi_host* trampolines when we just want to call straight into the host libC. b) Building in the native_simulator runner context (and therefore with the host C library) two functions which we call from the embedded side. Signed-off-by: Alberto Escolar Piedras <[email protected]>
This test itself (not the code under test) needs to be build with the host C library as it calls into its open/close/read/write APIs. So let's ensure we build it with it, independently of what the default C library may be. Signed-off-by: Alberto Escolar Piedras <[email protected]>
|
Member
Author
|
The last push was just to please SonarCloud |
tpambor
approved these changes
Dec 20, 2025
| CONFIG_MODEM_MODULES=y | ||
| CONFIG_MODEM_BACKEND_TTY=y | ||
|
|
||
| CONFIG_EXTERNAL_LIBC=y |
Contributor
There was a problem hiding this comment.
Maybe I am missing something but shouldn't this already be the default for native_sim?
Line 80 in 72360f8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we call into the host C library open/close/read/write independently of which embedded C library the code is built with.
We do this by:
a) Using the native simulator nsi_host* trampolines when we just want to call straight into the host libC.
b) Building in the native_simulator runner context (and therefore with the host C library) two functions which we call from the embedded side.
&
tests/subsys/modem/backends/tty: Ensure it is built with proper C lib
This test itself (not the code under test) needs to be build with the host C library as it calls into its open/close/read/write APIs.
So let's ensure we build it with it, independently of what the default C library may be.
Note there is minor functional change, the code before would block during polls during 100ms and then wait 100ms until the next poll. Now it does not block during polls (it just checks and returns immediately) and then waits 100ms.