modules: cmsis-dsp: update cmsis-dsp to v1.17.0#105315
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
area: DSP
area: Samples
b9eaab8 to
6887744
Compare
40e7063 to
513bae4
Compare
|
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
|
@stephanosio Can you please take a look? |
stephanosio
left a comment
stephanosio
left a comment
There was a problem hiding this comment.
The following options are no longer available:
Is there an alternative to these deleted options?
No, those options didn't really provide anything 'functional', they only made things compile ""faster""...
And that is a very important aspect, especially when there are hundreds of tests and samples built for hundreds of platforms.
We should keep the feature flags locally for now and ask the CMSIS-DSP upstream to add them in the future.
Removing these will significantly increase CI load for no good reason.
136fd9e to
3dce2f0
Compare
done..... also see ARM-software/CMSIS-DSP#310 |
The CMSIS-DSP module has been updated to maintain Kconfig and CMakeLists.txt in the module tree rather than external to zephyr. Remove references to the obsolete feature-level Kconfig options from all test and sample configurations. The following options are no longer available: - CONFIG_CMSIS_DSP_BASICMATH - CONFIG_CMSIS_DSP_BAYES - CONFIG_CMSIS_DSP_COMPLEXMATH - CONFIG_CMSIS_DSP_DISTANCE - CONFIG_CMSIS_DSP_FASTMATH - CONFIG_CMSIS_DSP_FILTERING - CONFIG_CMSIS_DSP_INTERPOLATION - CONFIG_CMSIS_DSP_MATRIX - CONFIG_CMSIS_DSP_QUATERNIONMATH - CONFIG_CMSIS_DSP_STATISTICS - CONFIG_CMSIS_DSP_SUPPORT - CONFIG_CMSIS_DSP_SVM - CONFIG_CMSIS_DSP_TRANSFORM Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
3dce2f0 to
1245aef
Compare
|
i spoke to the maintainer, he mentioned that v1.17.0 already got some compile time optimizations, while adding those "many kconfigs" back would give a small improvement now, i think it's rather better to reduce developer complexity here now reverting to previous commit now |
|
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note that if it gets closed, you can ask someone to reopen it for you if you do not have the permissions to do so. |
|
do you plan on looking at this @stephanosio ? already directly pinged on discord a while ago |
6 participants
The CMSIS-DSP module has been updated to maintain Kconfig and CMakeLists.txt in the module tree rather than external to zephyr. ARM-software/CMSIS-DSP now maintains the Kconfig and CMakeLists.txt in upstream repo (so no more custom patch on top of the zephyrproject/ fork) Remove references to the obsolete feature-level Kconfig options from all test and sample configurations.
The following options are no longer available: