[Backport v4.3-branch] mailbox: userspace: Fixes for mbox_send#110656
Open
github-actions[bot] wants to merge 2 commits into
Open
[Backport v4.3-branch] mailbox: userspace: Fixes for mbox_send#110656github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
handle msg == NULL explicitly since it is valid according with the API documentation. Signed-off-by: Flavio Ceolin <flavio@hubblenetwork.com> (cherry picked from commit d858a79)
The syscall verifier validated msg->data directly from live userspace memory and then forwarded the original mutable userspace struct pointer to z_impl_mbox_send(). A concurrent thread could race msg->data to a supervisor address after the access check. Fix this by copying struct mbox_msg into a kernel-stack variable. Signed-off-by: Flavio Ceolin <flavio@hubblenetwork.com> (cherry picked from commit ab35eac)
|
Member
|
@ceolin - can you please create an issue for the backport? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport ab35eac~2..ab35eac from #109946.
Original PR description:
Two fixes for mbox_send when userspace is enabled:
For more specific details look commit messages.