Skip to content

Conversation

jfischer-no
Copy link
Contributor

Make USB device-next samples default and move legacy code to legacy directory.

Copy link
Contributor

@tmon-nordic tmon-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also some CDC ACM twister failures, some where both USB stacks seem to be active simultaneously and some where there doesn't seem to be CDC ACM devicetree instance.

Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much same comment as last time this was proposed (see #80985 (comment)):

As already stated in an earlier comment on this PR (#80985 (review)) I do not think "device_next" is ready becoming the default USB device stack in Zephyr v4.1.

There's the issue with lack of "vendor" testing (tested it on a random selection of development boards, three of the new USB device drivers failed to enumerate on MS Windows), the lack of support for a number of platforms (I know some people find it acceptable to "leave these behind"), the list of open bug reports - and especially the vastly increased RAM/ROM footprint as reported in #83309. These are all mentioned in #42066 but not yet handled with 9 days until v4.1 feature freeze.

@jfischer-no jfischer-no force-pushed the pr-samples-usb-use-device_next branch from 53c9919 to 15be1f2 Compare March 26, 2025 12:08
@carlescufi
Copy link
Member

the lack of support for a number of platforms (I know some people find it acceptable to "leave these behind"),

We agreed those would not be a factor I believe, after I sent an informative email to devel@

the list of open bug reports

Which are those? I am not familiar with these.

and especially the vastly increased RAM/ROM footprint as reported in #83309.

Agreed, this needs to be addressed.

@henrikbrixandersen
Copy link
Member

Which are those? I am not familiar with these.

I meant the open issues reported against the device_next stack here on GitHub. Personally, I think the following would be relevant to look at before making this the default stack. Some of these have gone months without any maintainer feedback:

@carlescufi
Copy link
Member

I meant the open issues reported against the device_next stack here on GitHub. Personally, I think the following would be relevant to look at before making this the default stack. Some of these have gone months without any maintainer feedback:

I agree with you. @jfischer-no and @tmon-nordic could you please go over these and see what can be fixed?

@jfischer-no
Copy link
Contributor Author

I meant the open issues reported against the device_next stack here on GitHub. Personally, I think the following would be relevant to look at before making this the default stack. Some of these have gone months without any maintainer feedback:

I agree with you. @jfischer-no and @tmon-nordic could you please go over these and see what can be fixed?

I am on
#74058
#87732 (is not a bug)
#86718 (is not a bug)

@jfischer-no jfischer-no force-pushed the pr-samples-usb-use-device_next branch from b8ead61 to 8644103 Compare August 6, 2025 11:23
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Aug 6, 2025
@carlescufi
Copy link
Member

@fabiobaltieri @henrikbrixandersen @nandojve @jukkar @tmon-nordic
Last push is just bringing the MCUboot commit into Zephyr's fork.

@carlescufi carlescufi removed this from Release Plan Aug 6, 2025
@cfriedt cfriedt merged commit 9759ca6 into zephyrproject-rtos:main Aug 6, 2025
41 of 43 checks passed
@hakehuang
Copy link
Contributor

this breaks sample.net.sockets.http.server on many NXP platforms like mimxrt1170_evk

@ArekBalysNordic
Copy link
Contributor

@jfischer-no The legacy USB driver has been deprecated. Where can I find a migration guide to the new USB driver?

@jfischer-no
Copy link
Contributor Author

@jfischer-no The legacy USB driver has been deprecated. Where can I find a migration guide to the new USB driver?

There is no porting guide yet, but all the use cases are covered by the samples, so please take a look at samples/subsys/usb/cdc_acm, samples/subsys/usb/console, or, I guess, 895cc01 or 6c4847d may help you as well.

Cristib05 added a commit to nxp-upstream/zephyr that referenced this pull request Sep 25, 2025
Since multiple platforms than nrf are allowed to run this sample,
re-add generic openthread name for sample.

Initially, generic naming has been performed in zephyrproject-rtos#83195,
and then, a revert occurred in zephyrproject-rtos#87269

Signed-off-by: Cristian Bulacu <[email protected]>
kartben pushed a commit that referenced this pull request Sep 29, 2025
Since multiple platforms than nrf are allowed to run this sample,
re-add generic openthread name for sample.

Initially, generic naming has been performed in #83195,
and then, a revert occurred in #87269

Signed-off-by: Cristian Bulacu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.