-
Notifications
You must be signed in to change notification settings - Fork 8.1k
usb: make device-next default and move legacy sample code to legacy directory #87269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usb: make device-next default and move legacy sample code to legacy directory #87269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some CDC ACM twister failures, some where both USB stacks seem to be active simultaneously and some where there doesn't seem to be CDC ACM devicetree instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty much same comment as last time this was proposed (see #80985 (comment)):
As already stated in an earlier comment on this PR (#80985 (review)) I do not think "device_next" is ready becoming the default USB device stack in Zephyr v4.1.
There's the issue with lack of "vendor" testing (tested it on a random selection of development boards, three of the new USB device drivers failed to enumerate on MS Windows), the lack of support for a number of platforms (I know some people find it acceptable to "leave these behind"), the list of open bug reports - and especially the vastly increased RAM/ROM footprint as reported in #83309. These are all mentioned in #42066 but not yet handled with 9 days until v4.1 feature freeze.
53c9919
to
15be1f2
Compare
We agreed those would not be a factor I believe, after I sent an informative email to devel@
Which are those? I am not familiar with these.
Agreed, this needs to be addressed. |
I meant the open issues reported against the
|
I agree with you. @jfischer-no and @tmon-nordic could you please go over these and see what can be fixed? |
|
8644103
b8ead61
to
8644103
Compare
@fabiobaltieri @henrikbrixandersen @nandojve @jukkar @tmon-nordic |
this breaks sample.net.sockets.http.server on many NXP platforms like mimxrt1170_evk |
@jfischer-no The legacy USB driver has been deprecated. Where can I find a migration guide to the new USB driver? |
There is no porting guide yet, but all the use cases are covered by the samples, so please take a look at |
Since multiple platforms than nrf are allowed to run this sample, re-add generic openthread name for sample. Initially, generic naming has been performed in zephyrproject-rtos#83195, and then, a revert occurred in zephyrproject-rtos#87269 Signed-off-by: Cristian Bulacu <[email protected]>
Since multiple platforms than nrf are allowed to run this sample, re-add generic openthread name for sample. Initially, generic naming has been performed in #83195, and then, a revert occurred in #87269 Signed-off-by: Cristian Bulacu <[email protected]>
Make USB device-next samples default and move legacy code to legacy directory.