xtensa: xt-sim: CONFIG_BOOTARGS support #87295
Conversation
This change offers a more flexible approach in comparison to CONFIG_DYNAMIC_BOOTARGS, because the bootloader environment, as is in the case of Xtensa sim, has already done the work that get_bootargs() does. Signed-off-by: William Tambe <[email protected]>
This change enables the use of argc and argv with `main()`. Signed-off-by: William Tambe <[email protected]>
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis and
TaiJuWu
|
@dcpleung |
|
You can always exclude the board from the test. |
| // Reserve stack space for | ||
| // - argv array | ||
| // - argument strings |
There was a problem hiding this comment.
As for comments, we do /* */ style and not //. Please replace all of these.
Which file should I change to exclude the board from the test ? |
|
There should be a |
| @@ -188,6 +226,23 @@ _start: | |||
|
|
|||
| #endif /* !XCHAL_HAVE_BOOTLOADER */ | |||
|
|
|||
| #if defined(CONFIG_BOARD_XT_SIM) | |||
There was a problem hiding this comment.
FYI both SYS_iss_set_argv and SYS_iss_argc are available in QEMU
The 2nd change enables the use of argc and argv with
main().The 1st change is the prerequisite that makes prepare_main_args() a weak function,
as it offers a more flexible approach in comparison to CONFIG_DYNAMIC_BOOTARGS,
because the bootloader environment, as is in the case of Xtensa sim, has already done
the work that get_bootargs() does.