open-amp: resource table: Add support for vendor-specific features #87296
+66
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for vendor-specific features in the remote processor resource table. This is configurable based on the length of the vendor-specific resource. For header we are using struct fw_rsc_vendor from OpenAMP and an array of words to store vendor-specific features supported by the firmware. The supported features will be defined in CONFIG_OPENAMP_RSC_TABLE_VENDOR_DATA_FEATURES_X, where X represents the number of words needed (1 to 4). This enhancement allows better flexibility for remote processors requiring custom features configurations. Signed-off-by: Iuliana Prodan <[email protected]>
uLipe
reviewed
Mar 18, 2025
| config OPENAMP_RSC_TABLE_VENDOR_RSC_LENGTH | ||
| int "Vendor specific length of the resource" | ||
| default 0 | ||
| range 0 4 |
There was a problem hiding this comment.
Question instead of using the size to actually reserve space in the rsc_table, why not create a specific option let's ADD_VENDOR_SPEFICIC_AREA?
I'm afraid that implementors may use for example 0 - sized values and it silently have hard time to debug when this value is badly populated
Having a switch like option enforces the implementor to search the documentation to refer the "right" way to populate the vendor reserved area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for vendor-specific features in the remote processor resource table.
This is configurable based on the length of the vendor-specific resource.
For header we are using struct fw_rsc_vendor from OpenAMP and an array of words to store vendor-specific features supported by the firmware. The supported features will be defined in
CONFIG_OPENAMP_RSC_TABLE_VENDOR_DATA_FEATURES_X, where X represents the number of words needed (1 to 4).
This enhancement allows better flexibility for remote processors requiring custom features configurations.