drivers: ieee802154: nrf5: new RX window cancels previous RX #87964
Closed
e-rk wants to merge 2 commits intozephyrproject-rtos:mainfrom
Closed
drivers: ieee802154: nrf5: new RX window cancels previous RX #87964e-rk wants to merge 2 commits intozephyrproject-rtos:mainfrom
e-rk wants to merge 2 commits intozephyrproject-rtos:mainfrom
Conversation
The hal_nordic was updated to bring the new open source revision of the nrf-802154 radio driver. Signed-off-by: Rafał Kuźnia <rafal.kuznia@nordicsemi.no>
github-actions
Bot
requested review from
anangl,
cfriedt,
jukkar,
kl-cruz,
masz-nordic and
nika-nordic
|
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
github-actions
Bot
added
manifest
manifest-hal_nordic
DNM (manifest)
ankuns
reviewed
Apr 1, 2025
ankuns
reviewed
Apr 1, 2025
Comment on lines
+883
to
+886
| nrf_802154_receive_at(config->rx_slot.start / NSEC_PER_USEC, | ||
| config->rx_slot.duration / NSEC_PER_USEC, | ||
| config->rx_slot.channel, slot_id); |
Contributor
There was a problem hiding this comment.
nrf_802154_receive_at returns bool. What with the result?
Contributor
Author
There was a problem hiding this comment.
The previous implementation didn't use the return result. I kept the previous approach.
If proper error handling is desired, I would suggest that it's done more holistically in the entire file.
Contributor
There was a problem hiding this comment.
No I'm not forcing a change.,(void)nrf_802154_receive_at would be enough, to possibly satisfy some lint.
According to the documentation of IEEE802154_CONFIG_RX_SLOT, if the previous RX slot hasn't begun yet, but a new one is scheduled, then the previous RX slot must be cancelled. The new RX slot effectively replaces the old one. If the previous slot is currently ongoing, then it is not affected. The new RX slot can be scheduled while the previous slot is still ongoing. Signed-off-by: Rafał Kuźnia <rafal.kuznia@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the documentation of IEEE802154_CONFIG_RX_SLOT,
if the previous RX slot hasn't begun yet, but a new one is scheduled,
then the previous RX slot must be cancelled. The new RX slot effectively
replaces the old one.
If the previous slot is currently ongoing, then it is not affected. The
new RX slot can be scheduled while the previous slot is still ongoing.