drivers: wifi: infineon: add .iface_status method

[drensber]

The .iface_status method of the wifi_mgmt_ops API needs to be added so that the "wifi status" command on the network shell will work.

[jukkar]

Minor nits about the coding style, you could see what the rest of the airoc_wifi.c looks like and follow suit.

[drensber]

I changed all of these things according to your preferences. Looking at the Zephyr Coding Guidelines, I'm not sure that any of them are actually established rules, so perhaps that's why the automated checks didn't catch any of them.

[drensber]

I think the twister failure is a problem on your side, not a problem with the code that I pushed. Can someone look into this and re-run the tests?

[rlubos]

I think the twister failure is a problem on your side, not a problem with the code that I pushed. Can someone look into this and re-run the tests?

Looked like some environmental issue, I've retriggered failed stage, tests are now running.

[Copilot]

Pull Request Overview

This PR adds an .iface_status method to the Infineon WiFi driver so that the "wifi status" command on the network shell works as expected.

• Added the implementation of airoc_iface_status to report interface mode, state, SSID, channel, and other connection parameters.
• Updated the wifi_mgmt_ops structure to include the new .iface_status method.
• Introduced an additional header include for whd_wlioctl.h required by the new functionality.

Comments suppressed due to low confidence (1)

drivers/wifi/infineon/airoc_wifi.c:774

• The variable 'airoc_if' is referenced without a visible declaration in this diff. Verify that it is properly declared and initialized in an accessible scope before use.

if (airoc_if == NULL) {

[Copilot]

Using strncpy without explicitly appending a null terminator risks leaving status->ssid unterminated. Consider ensuring the string is null-terminated (and that the destination buffer is large enough) after copying.

Suggested change

	strncpy(status->ssid, bss_info.SSID, bss_info.SSID_len);
	if (status->ssid_len < sizeof(status->ssid)) {
	strncpy(status->ssid, bss_info.SSID, status->ssid_len);
	status->ssid[status->ssid_len] = '\0'; // Ensure null-termination
	} else {
	LOG_ERR("SSID length exceeds buffer size");
	return -EINVAL; // Return an error if the buffer is too small
	}

[drensber]

I think Copilot's advice is invalid in this particular case. The SSID is defined by zephyr to be a character string with a max length of 32 and an accompanying SSID_len field to specify the actual length. If I were to use one character of the ssid field as a null terminator, the maximum length would become 31.

[krish2718]

You don't need to NULL terminate SSID buffer in the status, but you are using source length to copy to destination, so, this can overflow, it's always better to use destination length or do explicit NULL checking.

[drensber]

Do I need to do anything else here, or are we just waiting for someone else to review?

[beechwoods-software]

@Kludentwo @rlubos @krish2718 @MaochenWang1 Could someone else please review this? My understanding is that after a certain amount of time (60 days?) it will just be closed to inactivity. I don't think this should be too controversial of a PR. Even if it isn't a perfect implementation, it's better than having "wifi status" or .iface_status() not work at all, and any deficiencies can be addressed after there's a baseline implementation in place.

[krish2718]

Please remove all whitespace changes or move them to a separate commit for easier review.

[krish2718]

You don't need to NULL terminate SSID buffer in the status, but you are using source length to copy to destination, so, this can overflow, it's always better to use destination length or do explicit NULL checking.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[drensber]

Can someone please restart the automated tests? They failed to even start for some reason "The job was not acquired by Runner of type hosted even after multiple attempts".

[drensber]

@jukkar Do you have the ability to restart the automated tests? They timed out when I did my latest push for some reason.

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

[drensber]

@jukkar How do I get the "Stale" label removed? I'd like to see this PR accepted. As far as I know, it's just waiting for further review.

[drensber]

@krish2718 @jukkar Again... What do I need to do to get this merged? As far as I'm aware, it's just waiting on review. Is there a way I can at least get the "Stale" tag removed so that it doesn't automatically close?

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.