drivers: ethernet: phy: add driver for ksz9131 #90711

TonyHan11 · 2025-05-28T04:31:42Z

This PR includes:

add the driver for Microchip KSZ9131 Ethernet PHY
add interrupt mode support for KSZ8081

pdgendt · 2025-05-28T07:00:55Z

Add an entry to https://github.com/zephyrproject-rtos/zephyr/blob/main/tests/drivers/build_all/ethernet/app.overlay so it builds in CI.

dts/bindings/ethernet/microchip,ksz9131.yaml

drivers/ethernet/phy/phy_microchip_ksz9131.c

TonyHan11 · 2025-05-28T08:15:27Z

@pdgendt An entry for ksz9131 added to tests/drivers/build_all/ethernet/app.overlay, thanks.

maass-hamburg · 2025-05-28T08:18:27Z

@TonyHan11 pls add PR description and address the things from sonarqube

TonyHan11 · 2025-05-28T08:19:09Z

@maass-hamburg updated with removing the unused property, renaming LINK_*BASED_T and fixing if (ret), thank you very much.

drivers/ethernet/phy/phy_microchip_ksz8081.c

drivers/ethernet/phy/phy_microchip_ksz9131.c

TonyHan11 · 2025-06-03T05:40:21Z

@maass-hamburg
Thank you for your comments. Commits updated with the following changes:

using goto instead of do while (0)
update if (ret) to if (ret < 0)
fix the issues reported by SonarQube Cloud
remove comments TODO change this to GPIO interrupt driven

drivers/ethernet/phy/Kconfig

TonyHan11 · 2025-06-09T05:29:49Z

Resolve the CI error by rebasing the commits (without changes).

drivers/ethernet/phy/phy_microchip_ksz8081.c

kartben · 2025-06-26T08:28:53Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	reg_val |= PHY_KSZ9131_ICS_LINK_UP_IE_MASK | PHY_KSZ9131_ICS_LINK_DOWN_IE_MASK;
+
+	/* Write settings to Interrupt Control/Status register */
+	ret = ksz9131_write(dev, 27, reg_val);


Use PHY_KSZ9131_ICS_REG macro instead of magic number

drivers/ethernet/phy/phy_microchip_ksz9131.c

kartben · 2025-06-26T08:41:53Z

drivers/ethernet/phy/phy_microchip_ksz8081.c

+		goto done;
+	}
+
+	gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,


Suggested change

gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

ret = gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

TonyHan11 · 2025-08-04T01:14:04Z

@TonyHan11 please rebase to current main

rebased, thanks.

drivers/ethernet/phy/phy_microchip_ksz9131.c

maass-hamburg · 2025-08-26T08:12:10Z

drivers/ethernet/phy/Kconfig

+	depends on MDIO
+	depends on GPIO || (!$(dt_compat_any_has_prop,$(DT_COMPAT_MICROCHIP_KSZ9131),reset-gpios) && \
+			    !$(dt_compat_any_has_prop,$(DT_COMPAT_MICROCHIP_KSZ9131),int-gpios))


apply changes from #94806

Rebased and updated with the changes applied.

maass-hamburg · 2025-08-26T08:15:47Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	uint16_t anar = 0;
+	int ret = 0;
+
+	(void)config; /* avoid warnings due to config is only used in LOG_DBG() */


use __maybe_unused attribute on config instead

Fixed, thanks.

maass-hamburg · 2025-08-26T08:29:29Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+		goto done;
+	}
+
+	ret = phy_mchp_ksz9131_autonegotiate(dev);


consider adding the changes from #93118 here too and using phy_mii_cfg_link_autoneg

Improve some of the logging.
No changes with auto-negotiate due to no block issue in ksz9131 using interrupt mode.
It seems that the interrupt mode for ksz8081 is not fully supported in the PR.

TonyHan11 · 2025-09-02T05:09:53Z

Dropped the commit for adding interrupt mode support for ksz8081 as it has conflicts with the code on mainline.
Will add it in a new PR once it works again.

TonyHan11 · 2025-09-02T06:23:27Z

Dropped the commit for adding interrupt mode support for ksz8081 as it has conflicts with the code on mainline. Will add it in a new PR once it works again.

Support for ksz8081 interrupt mode added in #95305

TonyHan11 · 2025-09-09T06:19:29Z

Updated ksz9131 driver with:

use if (USING_INTERRUPT_GPIO) to make code more concise
use __maybe_unused for variables in stead of using #if .. #endif
split init_int_gpios from phy_mchp_ksz9131_init()

maass-hamburg · 2025-09-09T07:03:40Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+		}
+	}
+
+	ret = phy_mchp_ksz9131_get_link(dev, &state);


might be good to apply the changes of 4683dae here too.

Applied by adding an additional commit.

maass-hamburg · 2025-09-09T07:12:44Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	} else {
+	}


call phy_mchp_ksz9131_speed here, instead of in phy_mchp_ksz9131_get_link

Added phy_mchp_ksz9131_speed() to the else branch inside phy_mchp_ksz9131_gigabit().

maass-hamburg · 2025-09-09T07:18:11Z

drivers/ethernet/phy/phy_microchip_ksz9131.c

+	ret = phy_mchp_ksz9131_update_anar(dev, adv_speeds);
+	if (ret < 0) {
+		goto done;
+	}
+
+	ret = ksz9131_read(dev, MII_1KTCR, &c1kt);
+	if (ret < 0) {
+		goto done;
+	}
+
+	if (adv_speeds & LINK_FULL_1000BASE) {
+		c1kt |= MII_ADVERTISE_1000_FULL;
+	} else {
+		c1kt &= ~MII_ADVERTISE_1000_FULL;
+	}
+
+	if (adv_speeds & LINK_HALF_1000BASE) {
+		c1kt |= MII_ADVERTISE_1000_HALF;
+	} else {
+		c1kt &= ~MII_ADVERTISE_1000_HALF;
+	}
+
+	ret = ksz9131_write(dev, MII_1KTCR, c1kt);
+	if (ret < 0) {
+		goto done;
+	}


if you don't want to use phy_mii_cfg_link_autoneg, at least use phy_mii_set_anar_reg and phy_mii_set_c1kt_reg

Replaced this lines with phy_mii_set_anar_reg and phy_mii_set_c1kt_reg, thanks a lot.

Add support for KSZ9131 (Gigabit Ethernet Transceiver with RGMII Support). As first starter, 100MBit/s mode is tested. https://www.microchip.com/en-us/product/ksz9131 Signed-off-by: Tony Han <[email protected]>

Add build tests for Microchip KSZ9131. Signed-off-by: Tony Han <[email protected]>

Enable Link-Up and Link-Down interrupts. On the interrupt handling the monitor work is scheduled to update the link status and calling corresponding callback routine. Signed-off-by: Tony Han <[email protected]>

Read gigabit status from Master Slave Status Register. Signed-off-by: Tony Han <[email protected]>

Get the link state in the monitor and save it for get_link api implementation to use. Signed-off-by: Tony Han <[email protected]>

sonarqubecloud · 2025-09-10T02:17:39Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nandojve · 2025-09-15T09:13:30Z

dts/bindings/ethernet/phy/microchip,ksz9131.yaml

+# Copyright (C) 2025 Microchip Technology Inc. and its subsidiaries
+# SPDX-License-Identifier: Apache-2.0
+
+description: Microchip KSZ9131 Ethernet PHY device


Hi @TonyHan11 ,

I think you already know:

re-order

split the content and put in the correct dependency order

you need board that uses this phy

github-actions bot added the area: Ethernet label May 28, 2025

github-actions bot requested review from a user, decsny, lmajewski, maass-hamburg and pdgendt May 28, 2025 04:32

github-actions bot assigned maass-hamburg May 28, 2025

maass-hamburg requested changes May 28, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 6944d51 to 5055226 Compare May 28, 2025 08:09

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 5055226 to cfd8c64 Compare May 29, 2025 01:21

maass-hamburg requested changes Jun 2, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 4 times, most recently from 1ac4658 to e7778f7 Compare June 3, 2025 04:41

maass-hamburg reviewed Jun 3, 2025

View reviewed changes

drivers/ethernet/phy/Kconfig Outdated Show resolved Hide resolved

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from ffe8e46 to 94224d7 Compare June 9, 2025 04:51

TonyHan11 requested a review from maass-hamburg June 9, 2025 05:30

maass-hamburg requested changes Jun 10, 2025

View reviewed changes

drivers/ethernet/phy/phy_microchip_ksz8081.c Outdated Show resolved Hide resolved

drivers/ethernet/phy/phy_microchip_ksz8081.c Outdated Show resolved Hide resolved

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 94224d7 to 35d32e6 Compare June 10, 2025 09:27

maass-hamburg previously approved these changes Jun 10, 2025

View reviewed changes

kartben reviewed Jun 26, 2025

View reviewed changes

maass-hamburg reviewed Aug 4, 2025

View reviewed changes

drivers/ethernet/phy/phy_microchip_ksz9131.c Show resolved Hide resolved

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 2 times, most recently from ef7bf97 to a2640e1 Compare August 4, 2025 09:40

TonyHan11 requested a review from maass-hamburg August 26, 2025 01:31

maass-hamburg requested changes Aug 26, 2025

View reviewed changes

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from a2640e1 to 93fc888 Compare August 28, 2025 07:20

zephyrbot requested a review from ClaCodes August 28, 2025 07:21

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 93fc888 to cc48784 Compare August 28, 2025 07:51

TonyHan11 requested a review from maass-hamburg August 28, 2025 08:29

TonyHan11 mentioned this pull request Aug 29, 2025

drivers: ethernet: sam: Add support to GMAC1 #95135

Open

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from cc48784 to 9201e0f Compare September 2, 2025 05:08

TonyHan11 mentioned this pull request Sep 2, 2025

drivers: ethernet: phy: update ksz8081 with interrupt support #95305

Merged

maass-hamburg changed the title ~~drivers: ethernet: phy: add driver for ksz9131, update ksz8081 with interrupt support~~ drivers: ethernet: phy: add driver for ksz9131 Sep 2, 2025

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch from 9201e0f to 7ecff65 Compare September 9, 2025 05:41

maass-hamburg requested changes Sep 9, 2025

View reviewed changes

TonyHan11 added 4 commits September 9, 2025 16:45

drivers: ethernet: phy: add Microchip's KSZ9131 PHY support

32057e0

Add support for KSZ9131 (Gigabit Ethernet Transceiver with RGMII Support). As first starter, 100MBit/s mode is tested. https://www.microchip.com/en-us/product/ksz9131 Signed-off-by: Tony Han <[email protected]>

tests: drivers: build_all: ethernet: Add KSZ9131 entry

97eb26f

Add build tests for Microchip KSZ9131. Signed-off-by: Tony Han <[email protected]>

drivers: ethernet: phy: ksz9131: add support for phy interrupt mode

301fd86

Enable Link-Up and Link-Down interrupts. On the interrupt handling the monitor work is scheduled to update the link status and calling corresponding callback routine. Signed-off-by: Tony Han <[email protected]>

drivers: ethernet: phy: ksz9131: add getting status for gigabit mode

4662072

Read gigabit status from Master Slave Status Register. Signed-off-by: Tony Han <[email protected]>

TonyHan11 force-pushed the phy_ksz9131_ksz8081 branch 3 times, most recently from 477a671 to 2b6b529 Compare September 10, 2025 01:51

drivers: ethernet: phy: ksz9131: save link state for get

2b6b529

Get the link state in the monitor and save it for get_link api implementation to use. Signed-off-by: Tony Han <[email protected]>

TonyHan11 requested a review from maass-hamburg September 10, 2025 05:59

nandojve requested changes Sep 15, 2025

View reviewed changes

	gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,
	ret = gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,

drivers: ethernet: phy: add driver for ksz9131 #90711

Are you sure you want to change the base?

drivers: ethernet: phy: add driver for ksz9131 #90711

Conversation

TonyHan11 commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pdgendt commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TonyHan11 commented May 28, 2025

Uh oh!

maass-hamburg commented May 28, 2025

Uh oh!

TonyHan11 commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TonyHan11 commented Jun 3, 2025

Uh oh!

Uh oh!

TonyHan11 commented Jun 9, 2025

Uh oh!

Uh oh!

Uh oh!

kartben Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TonyHan11 commented Aug 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TonyHan11 commented Sep 2, 2025

Uh oh!

TonyHan11 commented Sep 2, 2025

Uh oh!

TonyHan11 commented Sep 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 10, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

TonyHan11 commented May 28, 2025 •

edited

Loading

kartben Jun 26, 2025 •

edited

Loading