Skip to content

Conversation

jlbwoods
Copy link
Contributor

@jlbwoods jlbwoods commented Jun 2, 2025

Switch the default partitions for `raspberrypi` to use the `sysbuild`
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

Please refer to this PR for comments relating to this modification:
 - https://github.com/zephyrproject-rtos/mcuboot/pull/128

@github-actions github-actions bot added the size: XS A PR changing only a single line of code label Jun 2, 2025
@jlbwoods jlbwoods force-pushed the pr_dts_vendor_raspberrypi_sysbuild branch from 3131126 to 0d00c99 Compare June 2, 2025 17:37
@ajf58
Copy link
Contributor

ajf58 commented Jun 2, 2025

Please can you add some more detail to this PR? The PR summary is currently just repeating the 'what' of the commit message. Please provide the 'why': what's the purpose of this change?

@jlbwoods jlbwoods force-pushed the pr_dts_vendor_raspberrypi_sysbuild branch from 0d00c99 to 0bdac63 Compare June 2, 2025 18:52
@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 2, 2025

Please can you add some more detail to this PR? The PR summary is currently just repeating the 'what' of the commit message. Please provide the 'why': what's the purpose of this change?

Provided more detailed summary and re-posted here:

Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

Please refer to this PR for comments relating to this modification:

@jlbwoods jlbwoods force-pushed the pr_dts_vendor_raspberrypi_sysbuild branch from 0bdac63 to 6489599 Compare June 2, 2025 18:57
@jlbwoods jlbwoods force-pushed the pr_dts_vendor_raspberrypi_sysbuild branch from 6489599 to 83c4354 Compare June 3, 2025 23:52
@fabiobaltieri
Copy link
Member

Hey, this needs a rebase and force push to pick up the CI error workaround.

Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

Signed-off-by: John Lin <[email protected]>
@jlbwoods jlbwoods force-pushed the pr_dts_vendor_raspberrypi_sysbuild branch from 83c4354 to 8c47e06 Compare June 4, 2025 14:58
Copy link

sonarqubecloud bot commented Jun 4, 2025

@soburi
Copy link
Member

soburi commented Jun 4, 2025

Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

I don't believe it's necessary to do this.

@jlbwoods
Copy link
Contributor Author

jlbwoods commented Jun 4, 2025

Switch the default partitions for raspberrypi to use the sysbuild
partitions in order to be consistent with the default partitions for
other vendor defined partitions.

I don't believe it's necessary to do this.

Agree. Will close this PR.

@jlbwoods jlbwoods closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants