Add Power Management support to TI cc23x0 SoC #91401

bogdanovs · 2025-06-11T07:14:38Z

This series adds Power Management support to TI cc23x0 SoC.

Datasheet: https://www.ti.com/lit/ds/symlink/cc2340r5.pdf

sonarqubecloud · 2025-06-23T15:27:26Z

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jpanisbl · 2025-07-07T14:01:13Z

Hello @andyross @nordic-krch @vaishnavachath Would you mind reviewing this PR please when you are available ?

bogdanovs · 2025-07-21T08:34:29Z

Hi , @andyross @nordic-krch @teburd @vaishnavachath @vanti can you review when you have time ?

gumulka

Will have a deeper look later, but some preliminary comments.

drivers/timer/Kconfig.cc23x0_rtc

soc/ti/simplelink/cc23x0/soc.c

gumulka · 2025-08-31T12:51:46Z

boards/ti/lp_em_cc2340r5/lp_em_cc2340r5.dts

+	lfxosc: lf_xosc {
+		compatible = "ti,cc23x0-lf-xosc";
+	};


Wouldn't it be cleaner to declare it inside the cc23x0.dtsi and mark it as disabled and then enable it here?

Because as far as I can understand it, there is the possibility for a low frequency oscillator on all MCU's, but it is only placed here on the devboard.

This stand for Low Frequency External Oscillator which hardware component which could or could not be populated on different board with cc2340r5 SoCs.

External oscillator (LFXT): external 32.768 kHz crystal oscillator connected across the X32P input and X32N output pins.

soc/ti/simplelink/cc23x0/power.c

gumulka · 2025-08-31T13:17:15Z

soc/ti/simplelink/cc23x0/power.c

+	case PM_STATE_STANDBY:
+		pm_cc23x0_enter_standby();
+		break;


Wouldn't it make more sense to have the distinction here:

Suggested change

case PM_STATE_STANDBY:

pm_cc23x0_enter_standby();

break;

case PM_STATE_STANDBY:

#ifdef CONFIG_CC23X0_RTC_TIMER

Power_sleep(PowerLPF3_STANDBY);

#else

pm_cc23x0_enter_standby();

#endif

break;

Then you could also don't compile the function and anything related to it based on the kconfig option.

@gumulka your point here is to avoid having content of pm_cc23x0_enter_standby() compiled ?

drivers/timer/cc23x0_rtc_timer.c

gumulka · 2025-08-31T18:37:19Z

drivers/timer/cc23x0_rtc_timer.c

+			/* Reset timer and start from 0 */
+			HWREG(RTC_BASE + RTC_O_CTL) = 0x1;
+			HWREG(RTC_BASE + RTC_O_CH0CC8U) = ticks;


I did not quite understand this, but could it be, that this will make the calculation of the elapsed tick inaccurate, because the timer was reset and the last_rtc_count was not?

I am not sure I get your point. Can you elaborate if you think there is some kind of issue here ?

From datasheet :

RTC counter reset. Writing 1 to this bit will reset the RTC counter, and cause it to resume counting from 0x0 0h = No effect 1h = Reset the timer.

I believe this code to be correct, but in the function sys_clock_elapsed you calculate the elapsed time as elapsed_rtc = current_rtc_count - last_rtc_count;
If you reset the timer, then the value for last_rtc_count becomes irrelvant, as the timer itself was reset, making the calculations for sys_clock_elapsed wrong.

I think else case in get_elapsed_ticks_rtc address what you describe here, can you take look :

else { return ((0xFFFFFFFF - last_rtc_count) + current_rtc_count); }

drivers/timer/cc23x0_rtc_timer.c

gumulka · 2025-08-31T18:44:39Z

soc/ti/simplelink/cc23x0/Kconfig.defconfig

+		default 32768
+
+	config SYS_CLOCK_TICKS_PER_SEC
+		default 125375


Where does this value come from? It seems unusually large.

It was calculated , it is not a magic number. It is result from ticks which sys clock is making calculated to correct resolution

Could you share how it was calculated in the commit message or as a comment?

As RTC have 8us usable minimum resolution this result in 125000 ticks per second. 375 is compensation for the drift and round up/down because in normal operation mode RTC (and AON domain) is getting 1/2 of main 48Mhz clock which is 24Mhz.

soc/ti/simplelink/cc23x0/power.c

bogdanovs · 2025-09-26T06:57:48Z

With last update of the PR one more commit is added to solve UART PM issue which cause CI to fail with latest rebase on main

bogdanovs · 2025-10-02T12:35:33Z

Hi , @andyross @nordic-krch @vaishnavachath @vanti @dcpleung can you review when you have time ?

Add support for RTC as timer for cc23x0 SoC. Signed-off-by: Stoyan Bogdanov <[email protected]>

Add choice menu where could be selected between RTC or SYSTIM for system timer. Signed-off-by: Stoyan Bogdanov <[email protected]>

In case RTC is used for system timer, it should not be used as counter device. Dependency restricts counter driver to work only with SYSTIM. Signed-off-by: Stoyan Bogdanov <[email protected]>

Add conditonal definition for RTC and SYSTIM with different values for both of them respecting clock speed and ticks per minute. Signed-off-by: Stoyan Bogdanov <[email protected]>

External 32.768 kHz crystal oscillator (LFXT) connected across the X32P input and X32N output pins. Signed-off-by: Julien Panis <[email protected]>

Enable external 32 kHz crystal oscillator. Signed-off-by: Julien Panis <[email protected]>

Add power management capabilities for cc23x0: - runtime-idle - standby - soft-off Signed-off-by: Stoyan Bogdanov <[email protected]>

In power management, add conditions to handle the case where RTC is used as main timer. Signed-off-by: Stoyan Bogdanov <[email protected]>

In power management, add support to take into account the alarms set in RTC. Alarm from RTC is processed like any other from SYSTIM. This prevents from missing interrupts. Signed-off-by: Stoyan Bogdanov <[email protected]>

Add support for PM to cc23x0 SoC. Signed-off-by: Stoyan Bogdanov <[email protected]> Signed-off-by: Julien Panis <[email protected]>

Replace CONFIG_PM with CONFIG_PM_DEVICE to include pm_lock in cc23x0 UART driver in struct uart_cc23x0_data Signed-off-by: Stoyan Bogdanov <[email protected]>

kartben · 2025-10-15T13:28:57Z

re-assigning to TI SimpleLink maintainer.
@bjarki-andreasen maybe you can help review too? Thanks!

sonarqubecloud · 2025-10-15T13:40:48Z

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bjarki-andreasen · 2025-10-15T14:46:58Z

dts/arm/ti/cc23x0.dtsi

+			/* PM_STATE_SOFT_OFF can be entered only by calling pm_state_force */
+			state2: state2 {
+				compatible = "zephyr,power-state";
+				power-state-name = "soft-off";
+				min-residency-us = <0>;
+				exit-latency-us = <0>;
+				status = "disabled";
+			};


sys_poweroff() exists now which is an API which actually has a clear, non violating promise, please consider using it instead of reusing the PM framework, since its designed to work with states which don't loose system context, which soft off violates (hence the need to force the system into this state)

It might be part of the future work done on this SoC, thanks for the suggestion. At that point I would like avoid major changes if not strictly necessary since they will slow down this PR even more and it is blocking 4 more pending PRs.

github-actions bot added area: Counter area: Timer Timer platform: TI SimpleLink Texas Instruments SimpleLink MCU labels Jun 11, 2025

github-actions bot requested review from andyross, nordic-krch, teburd, vaishnavachath and vanti June 11, 2025 07:15

github-actions bot assigned andyross Jun 11, 2025

bogdanovs force-pushed the sbogdanov/upstream-cc23x0-pm-base branch 3 times, most recently from c1c1969 to 956ad83 Compare June 12, 2025 20:35

This was referenced Jun 13, 2025

Add Power Management support to GPIO for TI cc23x0 SoC #91609

Open

Add Power Management support to LGPT for TI cc23x0 SoC #91610

Open

Add Power Management support to RTC counter driver for TI cc23x0 SoC #91611

Open

bogdanovs force-pushed the sbogdanov/upstream-cc23x0-pm-base branch from 956ad83 to f6397be Compare June 17, 2025 05:07

github-actions bot added the area: Clock Control label Jun 17, 2025

bogdanovs force-pushed the sbogdanov/upstream-cc23x0-pm-base branch from f6397be to b7b48d6 Compare June 23, 2025 15:01

gumulka reviewed Aug 31, 2025

View reviewed changes

teburd removed their request for review September 17, 2025 20:49

bogdanovs force-pushed the sbogdanov/upstream-cc23x0-pm-base branch from b7b48d6 to 8d51cd5 Compare September 23, 2025 21:52

bogdanovs force-pushed the sbogdanov/upstream-cc23x0-pm-base branch 3 times, most recently from 196d044 to eece3c2 Compare September 24, 2025 20:22

zephyrbot added the area: UART Universal Asynchronous Receiver-Transmitter label Sep 25, 2025

zephyrbot requested a review from dcpleung September 25, 2025 13:06

bogdanovs requested a review from gumulka October 1, 2025 08:39

bogdanovs and others added 11 commits October 15, 2025 16:20

drivers: timer: Add RTC timer driver for cc23x0

12a9589

Add support for RTC as timer for cc23x0 SoC. Signed-off-by: Stoyan Bogdanov <[email protected]>

drivers: timer: cc23x0: Add option to select between RTC and SYSTIM

46f8413

Add choice menu where could be selected between RTC or SYSTIM for system timer. Signed-off-by: Stoyan Bogdanov <[email protected]>

drivers: counter: cc23x0: Add dependency for RTC

eca8d2c

In case RTC is used for system timer, it should not be used as counter device. Dependency restricts counter driver to work only with SYSTIM. Signed-off-by: Stoyan Bogdanov <[email protected]>

soc: ti: cc23x0: Add clock definition for RTC

c654e09

Add conditonal definition for RTC and SYSTIM with different values for both of them respecting clock speed and ticks per minute. Signed-off-by: Stoyan Bogdanov <[email protected]>

dts: bindings: clock: Add TI cc23x0 external low-frequency oscillator

90aebf7

External 32.768 kHz crystal oscillator (LFXT) connected across the X32P input and X32N output pins. Signed-off-by: Julien Panis <[email protected]>

boards: ti: lp_em_cc2340r5: Add external low-frequency oscillator

e30b294

Enable external 32 kHz crystal oscillator. Signed-off-by: Julien Panis <[email protected]>

soc: ti: cc23x0: Add power management

5f9221d

Add power management capabilities for cc23x0: - runtime-idle - standby - soft-off Signed-off-by: Stoyan Bogdanov <[email protected]>

soc: ti: cc23x0: Add conditions for RTC as timer in power.c

90cca7a

In power management, add conditions to handle the case where RTC is used as main timer. Signed-off-by: Stoyan Bogdanov <[email protected]>

soc: ti: cc23x0: Add support for RTC alarms in power.c

4ddcfb8

In power management, add support to take into account the alarms set in RTC. Alarm from RTC is processed like any other from SYSTIM. This prevents from missing interrupts. Signed-off-by: Stoyan Bogdanov <[email protected]>

dts: arm: ti: cc23x0: Add power management support

06e3492

Add support for PM to cc23x0 SoC. Signed-off-by: Stoyan Bogdanov <[email protected]> Signed-off-by: Julien Panis <[email protected]>

drivers: serial: cc23x0: Replace incorrect macros

5f9dc67

Replace CONFIG_PM with CONFIG_PM_DEVICE to include pm_lock in cc23x0 UART driver in struct uart_cc23x0_data Signed-off-by: Stoyan Bogdanov <[email protected]>

bogdanovs force-pushed the sbogdanov/upstream-cc23x0-pm-base branch from a584b8d to 5f9dc67 Compare October 15, 2025 13:22

zephyrbot added area: Boards/SoCs area: Devicetree Bindings labels Oct 15, 2025

kartben assigned vaishnavachath and unassigned andyross Oct 15, 2025

kartben requested review from bjarki-andreasen and removed request for gumulka October 15, 2025 13:29

bjarki-andreasen reviewed Oct 15, 2025

View reviewed changes

bjarki-andreasen approved these changes Oct 15, 2025

View reviewed changes

Add Power Management support to TI cc23x0 SoC #91401

Are you sure you want to change the base?

Add Power Management support to TI cc23x0 SoC #91401

Uh oh!

Conversation

bogdanovs commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 23, 2025

Quality Gate passed

Uh oh!

jpanisbl commented Jul 7, 2025

Uh oh!

bogdanovs commented Jul 21, 2025

Uh oh!

gumulka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bogdanovs commented Sep 26, 2025

Uh oh!

bogdanovs commented Oct 2, 2025

Uh oh!

kartben commented Oct 15, 2025

Uh oh!

sonarqubecloud bot commented Oct 15, 2025

Quality Gate passed

Uh oh!

bjarki-andreasen Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bogdanovs commented Jun 11, 2025 •

edited

Loading

bjarki-andreasen Oct 15, 2025 •

edited

Loading