Skip to content

Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add Bluetooth HCI driver for SiFli SF32LB chipsets. #96692

wants to merge 10 commits into from
+772 −6

Conversation

gangheivt
Copy link

@gangheivt gangheivt commented Sep 29, 2025 •
edited
Loading

This PR is to add Bluetooth HCI driver for SiFli SF32LB chipsets. The driver is using SiFli specific IPC mailbox to communicate with SF32LB Bluetooth controller running on LCPU core in the chipset,

@github-actions GitHub Actions
Copy link

Hello @gangheivt, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@Thalley Thalley removed their request for review September 29, 2025 07:34
gmarull
gmarull reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is missing a PR in HAL and a manifest update?

@gangheivt
Copy link
Author

looks like this is missing a PR in HAL and a manifest update?
Please refer to this PR.
zephyrproject-rtos/hal_sifli#1
Thanks

@gmarull
Copy link
Member

gmarull commented Sep 30, 2025

looks like this is missing a PR in HAL and a manifest update?
Please refer to this PR.
zephyrproject-rtos/hal_sifli#1
Thanks

Manifest needs to be updated accordingly

@jhedberg
Copy link
Member

jhedberg commented Oct 3, 2025

@gangheivt as requested in #96692 (comment) you need to add the appropriate reference in west.yml to your HAL PR as per https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules

Additionally, please do a rebase to get rid of the merge commits - those are not allowed in Zephyr pull requests.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_sifli zephyrproject-rtos/hal_sifli@7be4210 (main) zephyrproject-rtos/hal_sifli#1 zephyrproject-rtos/hal_sifli#1/files

Additional metadata changed:

Name URL Submodules West cmds module.yml Blobs
hal_sifli ✏ 2x 🆕

⛔ DNM label due to: 1 project with PR revision, 1 project with metadata changes and 2 blob changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

module: sifli: kconfig: Add Bluetooth HCI driver configuration
c9dd4d2 
Add SiFli Bluetooth HCI driver configurations.

Signed-off-by: Gang He <[email protected]>
@gangheivt gangheivt force-pushed the main branch 3 times, most recently from 4093b68 to 0402d21 Compare October 10, 2025 06:12
@gmarull
Copy link
Member

gmarull commented Oct 13, 2025

0402d21 is still wrong: does not point to a PR, so CI cannot even run. Please add "ble" to the board's "supported" list.

@gangheivt
Copy link
Author

0402d21 is still wrong: does not point to a PR, so CI cannot even run. Please add "ble" to the board's "supported" list.

Done

@gangheivt gangheivt closed this Oct 15, 2025
@gangheivt gangheivt reopened this Oct 15, 2025
@cvinayak cvinayak removed their request for review October 15, 2025 06:43
jhedberg
jhedberg reviewed Oct 15, 2025
View reviewed changes
@zephyrbot zephyrbot requested a review from jhedberg October 16, 2025 02:02
@jhedberg jhedberg mentioned this pull request Oct 16, 2025
Open
jhedberg
jhedberg requested changes Oct 16, 2025
View reviewed changes
@zephyrbot zephyrbot requested a review from jhedberg October 16, 2025 10:58
Gang He added 8 commits October 18, 2025 10:33
soc: sifli: sf32: Add configuration for Bluetooth HCI driver support
da285c0 
Add configuration support for Bluetooth HCI driver.

Signed-off-by: Gang He <[email protected]>
board: sifli: sf32lb52_devkit_lcd: Add mailbox in board device tree
f99605c 
Add mailbox in board devicetree, used in Bluetooth HCI driver.

Signed-off-by: Gang He <[email protected]>
driver: bluetooth: hci: sifli: Add configuration for SF32LB HCI driver.
d9cea90 
Add configuration for SiFli SF32LB chipset Bluetooth HCI driver.

Signed-off-by: Gang He <[email protected]>
module: hal_sifli: Add CMakefile script for bluetooth HCI driver.
78c324a 
Add CMakefile script needed for Bluetooth HCI driver.

Signed-off-by: Gang He <[email protected]>
module: hal_sifli: Overwrite SiFli HAL delay function with k_sleep
e9d6281 
SiFli HAL is using HAL_Delay_us to delay for certain microseconds.
This is a weak function. I overwrites this function with Zephyr k_sleep.

Signed-off-by: Gang He <[email protected]>
module: hal_sifli: Add IPC zephyr porting header file.
fe303b0 
Add SF32LB IPC zephyr porting header file.

Signed-off-by: Gang He <[email protected]>
driver: bluetooth: hci: sifli: Add SF32LB Bluetooth HCI driver.
a69e427 
Add Bluetooth driver for SF32LB chipsets.

Signed-off-by: Gang He <[email protected]>
west.yml: hal_sifli: Update to latest revision
9678020 
- Add Bluetooth HCI driver support for SF32LB chipsets

Signed-off-by: Gang He <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@cameled cameled Awaiting requested review from cameled

@HaavardRei HaavardRei Awaiting requested review from HaavardRei

@hermabe hermabe Awaiting requested review from hermabe

@HoZHel HoZHel Awaiting requested review from HoZHel

@PavelVPV PavelVPV Awaiting requested review from PavelVPV

@sjanc sjanc Awaiting requested review from sjanc

@erwango erwango Awaiting requested review from erwango

@FRASTM FRASTM Awaiting requested review from FRASTM

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@gmarull gmarull Awaiting requested review from gmarull

@jhedberg jhedberg Awaiting requested review from jhedberg

Requested changes must be addressed to merge this pull request.

Assignees

@jhedberg jhedberg

@alwa-nordic alwa-nordic

Labels

area: Bluetooth HCI Bluetooth HCI Driver area: Bluetooth area: Boards/SoCs area: Devicetree Bindings Binary Blobs Added DNM (manifest) This PR should not be merged (controlled by action-manifest) manifest manifest-hal_sifli platform: SF32LB

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gangheivt @gmarull @jhedberg @kartben @zephyrbot @alwa-nordic