Skip to content

fix: path traversal in download_job_artifacts local_path #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brennanneoh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: path traversal in download_job_artifacts local_path #644

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96c0401
fix: prevent path traversal in downloadJobArtifacts local_path
brennanneoh Aug 7, 2026
4426f29
fix: address CodeRabbit review on download_job_artifacts traversal fix
brennanneoh Aug 8, 2026
bbd734f
fix: avoid false pass in traversal rejection tests
brennanneoh Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7486,7 +7486,21 @@ async function downloadJobArtifacts(
await handleGitLabError(response);

const filename = `artifacts_job_${encodeGitLabPathSegment(jobId)}.zip`;
const savePath = localPath ? path.join(localPath, filename) : filename;
let savePath: string;
if (localPath) {
const normalizedLocalPath = path.normalize(localPath);
if (
path.isAbsolute(normalizedLocalPath) ||
normalizedLocalPath === ".." ||
normalizedLocalPath.startsWith(".." + path.sep) ||
normalizedLocalPath.includes(path.sep + ".." + path.sep)
) {
throw new Error("Invalid local_path: directory traversal is not allowed.");
Comment thread
brennanneoh marked this conversation as resolved.
Outdated
}
savePath = path.join(normalizedLocalPath, filename);
Comment thread
brennanneoh marked this conversation as resolved.
Outdated
Comment thread
brennanneoh marked this conversation as resolved.
Outdated
} else {
savePath = filename;
}
fs.mkdirSync(path.dirname(savePath), { recursive: true });

if (!response.body) {
Expand Down