Add Deno CI workflow for linting and testing - #647
Conversation
This workflow installs Deno and runs linting and tests on push and pull request events.
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdded a GitHub Actions workflow for ChangesDeno CI
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deno.yml:
- Line 30: Update the denoland/setup-deno action reference in the workflow to a
verified v2 commit SHA that runs on the target GitHub Actions runner, replacing
the Node 16-based v1.1.2 pin. Preserve the separately configured Deno runtime
version so changing the action major does not alter the requested Deno version.
- Line 32: Update the deno-version setting in the CI workflow from the v1.x
range to an exact repository-supported Deno release, preserving the
compatibility job while preventing automatic patch-version changes.
- Around line 11-15: Add a workflow-level concurrency configuration to the Deno
workflow, grouping runs by workflow name and ref and enabling cancel-in-progress
so superseded push or pull request runs are canceled while the newest run
proceeds.
- Around line 25-26: Update the checkout step using actions/checkout@v4 to pin
the action to commit 11d5960a326750d5838078e36cf38b85af677262, while retaining
the release comment # v4.4.0.
- Around line 25-26: Update the actions/checkout step in the “Setup repo”
workflow step to set persist-credentials to false, ensuring the later deno test
-A execution cannot access persisted checkout credentials.
- Line 42: Update the pull-request test workflow’s `deno test -A` command to use
only the required path-, host-, and executable-scoped Deno permissions. Set
`persist-credentials: false` on the `actions/checkout` step unless Git
authentication is required, and move any tests needing broader permissions to a
trusted workflow rather than granting them to every pull-request run.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 41ad1504-3e42-49f7-88ae-1dbd7fe09e1c
📒 Files selected for processing (1)
.github/workflows/deno.yml
📜 Review details
🧰 Additional context used
🪛 zizmor (1.29.0)
.github/workflows/deno.yml
[warning] 25-26: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[error] 26-26: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
[info] 21-21: workflow or action definition without a name (anonymous-definition): this job
(anonymous-definition)
[warning] 11-15: insufficient job-level concurrency limits (concurrency-limits): workflow is missing concurrency setting
(concurrency-limits)
🔇 Additional comments (1)
.github/workflows/deno.yml (1)
1-10: LGTM!Also applies to: 17-18, 20-24, 34-39, 41-41
This workflow installs Deno and runs linting and tests on push and pull request events.