[ core/pre-review ]github-actions pre-review by LaurelineP · Pull Request #3045 · zero-to-mastery/Animation-Nation

LaurelineP · 2025-10-05T02:00:39Z

Core and maintenance PR: Pre-review workflow

Purpose:

Automates pre-review feedback, label management, and contributor assignment to streamline the review process.
Labels: Changes Requested, invalid ,hacktoberfest-accepted

Goals

🔸 For maintainers

Facilitate reviews
- Check generic review points specific to this repo
- Generate a feedback message
- Automatically label PRs (e.g., "Changes Requested" and "Invalid")

🔸 For Students

Provide quick feedback based on requirements we can do while reviewing PRs
- Identify required files or invalid contributions
- Highlight missing content or incomplete code

Note

Here are the points I couldn’t go further with or that raise questions:

Manual review actions (“approve” or “request changes”) when submitting the final review manually — I can’t test this on my own PR.
What triggers zero-bot to rerun the GitHub Action and post multiple comments.

Definitely not blocking - should be good to use as is.

🧪 Local Testing

Test different review feedback locally.

This script reviews contributors’ submissions, ensuring no files are added outside the Art/ folder.

 ⚠️ Note: Labels and assignments are not checked since this runs within GitHub CI/CD.

 ⚠️ Note: Using act to test the github actions locally will fail because of gh not installed in their docker images.

Steps

Create a mock Art contribution (e.g., wrong filenames, JS in HTML, incorrect stylesheet, etc.).
Commit your changes

Run the script locally with your own variables (copy/paste into your terminal):


GITHUB_HANDLE=YourHandle \
GITHUB_PERMISSION_ROLE=admin \
CHANGED_FILES="$(git diff --name-only master  | tr '\n' ' ')" \
node ./generators/preReview.js

Experiment with: Code commands changing roles (admin | maintain - considered as maintainer ) or any other ( considered as contributor )
- Different GITHUB_HANDLE values.
- Changing GITHUB_PERMISSION_ROLE:
  - admin / maintain → no feedback for files outside Art/.
  - any other role → feedback includes out-of-scope files.

Demo.test.local.-.different.behavior.as.maintainer.or.contributor.mov

Visual Example

Auto-generated preview with feedback list ot address

Auto-generated preview with final feedback when addressed

MattCSmith · 2025-10-07T16:23:06Z

This is really cool @LaurelineP
Love the direction this is going in 🚀

…cking a contribution submission Updated workflow: - testing and fixing different cases: current expecting an error in html for invalid stylesheet name

zero-to-mastery-bot · 2025-10-08T15:58:12Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	433	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
7	382	3698

zero-to-mastery-bot · 2025-10-08T15:58:25Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	433	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
7	382	3698

zero-to-mastery-bot · 2025-10-08T15:58:28Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	433	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
7	382	3698

zero-to-mastery-bot · 2025-10-08T16:11:00Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	434	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
7	382	3698

github-actions · 2025-10-08T16:11:41Z

Aloha @LaurelineP 🙌 Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

Overall feedback
- Missing files in your contribution: include all required files inside the Art/ folder
  (3 files expected)
- Remove unnecessary file: Art/LaurelineP/test-workflow/icon.png - icons are auto-generated after merge
- Remove unnecessary file: Art/LaurelineP/test-workflow/index.js - not allowed for animations
- Space(s) detected in file or folder name(s) - please remove them.
HTML feedback for Art/LaurelineP/test-workflow/index.html
- Remove any JavaScript content from your HTML file
- Missing linked stylesheet file: link the CSS file to your HTML
CSS feedback for Art/LaurelineP/test-workflow/styke.css
- Incorrect filename: please rename your file as recommended
- Missing animation: include at least one @Keyframesdefinition and use theanimation` property

Happy Coding! 🚀

github-actions · 2025-10-08T17:05:46Z

github-actions · 2025-10-08T23:37:05Z

Aloha @LaurelineP 🙌 - Thanks for your contribution!

🎉 Your submission meets all pre-review requirements!
It’s now awaiting final validation from a maintainer.

Happy Coding! 🚀

zero-to-mastery-bot · 2025-10-08T23:41:03Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-08T23:41:22Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-08T23:42:02Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

github-actions · 2025-10-08T23:43:12Z

Aloha @LaurelineP 🙌 - Thanks for your contribution!

🎉 Your submission meets all pre-review requirements!
It’s now awaiting final validation from a maintainer.

Happy Coding! 🚀

zero-to-mastery-bot · 2025-10-08T23:44:31Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-08T23:45:39Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-08T23:46:01Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-08T23:46:04Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-08T23:57:01Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-09T03:41:17Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

zero-to-mastery-bot · 2025-10-09T08:39:04Z

🙏 Thanks for your pull request @LaurelineP, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are

PR Statistics

#️⃣ PR Number:	➕ Line Additions:	🗑️ Line Deletions:
3045	416	0

📑 Files Changed:	⭐ Repo Stars:	🔱 Total Forks:
2	382	3698

github-actions · 2025-10-09T08:40:00Z

Aloha @LaurelineP 🙌 - Thanks for your contribution!

🎉 Your submission meets all pre-review requirements!
It’s now awaiting final validation from a maintainer.

Happy Coding! 🚀

LaurelineP force-pushed the core/pre-review branch 18 times, most recently from 53aa7da to 8dbc48d Compare October 7, 2025 10:01

This comment was marked as outdated.

Sign in to view

LaurelineP force-pushed the core/pre-review branch from 8dbc48d to a80fb89 Compare October 7, 2025 10:08

This comment was marked as outdated.

Sign in to view

LaurelineP force-pushed the core/pre-review branch 7 times, most recently from ad42264 to b4c7e9d Compare October 7, 2025 11:27

zero-to-mastery deleted a comment from zero-to-mastery-bot Bot Oct 7, 2025

LaurelineP force-pushed the core/pre-review branch from 9ffbe17 to be93442 Compare October 7, 2025 13:24

github-actions Bot assigned LaurelineP Oct 7, 2025

LaurelineP removed invalid This doesn't seem right Changes Requested labels Oct 7, 2025

LaurelineP removed their assignment Oct 7, 2025

[ core/pre-review ] Checking other pre-review feedback cases while mo…

f7f7733

…cking a contribution submission Updated workflow: - testing and fixing different cases: current expecting an error in html for invalid stylesheet name

[ core/pre-review ] Refacto, adjustments and extra tests

d6c2c77

Merge branch 'master' into core/pre-review

648b98a

Merge branch 'master' into core/pre-review

8b93132

MattCSmith approved these changes Oct 10, 2025

View reviewed changes

Conversation

LaurelineP commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core and maintenance PR: Pre-review workflow

Goals

🧪 Local Testing

Steps

Visual Example

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

MattCSmith commented Oct 7, 2025

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

github-actions Bot commented Oct 8, 2025

Feedback

Uh oh!

github-actions Bot commented Oct 8, 2025

Feedback

Uh oh!

github-actions Bot commented Oct 8, 2025

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

github-actions Bot commented Oct 8, 2025

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 8, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 9, 2025

PR Statistics

Uh oh!

zero-to-mastery-bot Bot commented Oct 9, 2025

PR Statistics

Uh oh!

github-actions Bot commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LaurelineP commented Oct 5, 2025 •

edited

Loading