Skip to content

feat: Add 'Submit Your Art' button to header#3316

Closed
nilisofficiel wants to merge 1 commit into
zero-to-mastery:masterfrom
nilisofficiel:feature/add-submit-art-button
Closed

feat: Add 'Submit Your Art' button to header#3316
nilisofficiel wants to merge 1 commit into
zero-to-mastery:masterfrom
nilisofficiel:feature/add-submit-art-button

Conversation

@nilisofficiel
Copy link
Copy Markdown

Ajout d'un bouton 'Soumettre votre Œuvre' dans le header pour diriger les utilisateurs vers le fichier CONTRIBUTING.md et encourager les contributions

@github-actions
Copy link
Copy Markdown

Aloha @nilisofficiel 🙌 - Thanks for your contribution!
Before we can merge your submission, please address the following points.

Feedback

Tip

You can refer to README.md for additional guidance.

  • Overall feedback
    Reminder: the contribution should have 3 files in a folder in Art
    • Unauthorised changes:
      - please remove any changes in index.html
      - please remove any changes in public/styles.css

Happy Coding! 🚀

Copy link
Copy Markdown
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aloha @nilisofficiel 🙌
Thanks for your contributions however I am not sure this one will pass.

Here are the feedback and reasons:

  1. Your button's text is statically in french - this needs to be English first
  2. The ideas is nice / but misleading UX wise:
  • "submit" reflects the idea of being able to submit in-app / in-site an animation interactively.
    Whereas, here, the buttons is redirecting to the /CONTRIBUTIONS.md file - which does not exist in the project –Tips: always try to make sure your links are correct especially relative one - and check if the file exist.

This would be a great idea for another app oriented project (E.g.: app allowing the user to submit a contribution from the web page app).
However here, this is a repo to encourage developers to get their hands dirty, manipulating git, forking, github and coding while following the recommendation - to provide an experience of creating codebase addition.

In conclusion, this button doesn't convey with the current site here.
If any questions, feel free to reach out 🙌

Contente de voir tout de même un peu de contributions française :)
Happy coding !

@LaurelineP LaurelineP closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants