feat: Add 'Submit Your Art' button to header#3316
Conversation
|
Aloha @nilisofficiel 🙌 - Thanks for your contribution! FeedbackTip You can refer to README.md for additional guidance.
Happy Coding! 🚀 |
LaurelineP
left a comment
There was a problem hiding this comment.
Aloha @nilisofficiel 🙌
Thanks for your contributions however I am not sure this one will pass.
Here are the feedback and reasons:
- Your button's text is statically in french - this needs to be English first
- The ideas is nice / but misleading UX wise:
- "submit" reflects the idea of being able to submit in-app / in-site an animation interactively.
Whereas, here, the buttons is redirecting to the/CONTRIBUTIONS.mdfile - which does not exist in the project –Tips: always try to make sure your links are correct especially relative one - and check if the file exist.
This would be a great idea for another app oriented project (E.g.: app allowing the user to submit a contribution from the web page app).
However here, this is a repo to encourage developers to get their hands dirty, manipulating git, forking, github and coding while following the recommendation - to provide an experience of creating codebase addition.
In conclusion, this button doesn't convey with the current site here.
If any questions, feel free to reach out 🙌
Contente de voir tout de même un peu de contributions française :)
Happy coding !
Ajout d'un bouton 'Soumettre votre Œuvre' dans le header pour diriger les utilisateurs vers le fichier CONTRIBUTING.md et encourager les contributions