Rename VTwin90 folders to vanjatorp-* and update meta.json with new username#3326
Merged
Conversation
|
Aloha @vanjatorp 🙌 - Thanks for your contribution! FeedbackTip You can refer to README.md for additional guidance.
Happy Coding! 🚀 |
github-actions
Bot
added
Changes Requested
Conflict Present
|
Aloha @vanjatorp 🙌 - Thanks for your contribution! FeedbackTip You can refer to README.md for additional guidance.
Happy Coding! 🚀 |
Contributor
Author
|
Hi maintainers 👋 I’ve updated my contribution to reflect my new GitHub handle vanjatorp. The old VTwin90-* folders were renamed and are no longer part of my workspace, but they still appear in the PR diff as “deleted.” That seems to be why the automated bot flagged them as missing or incorrectly named. For clarity: All of my current folders are now named vanjatorp-*. Each folder contains the required three files: index.html, styles.css, and meta.json. I’ve removed all icon.png files as requested. My Pac‑Man animation already includes @Keyframes and animation: — nothing in the code itself has changed, only the folder names and meta.json.. So the bot feedback about the old VTwin90-* folders I think is just a side effect of the rename. The new vanjatorp-* folders are complete and follow the repo guidelines. Thanks for reviewing, and I appreciate your help in merging this update 🙏 |
|
Aloha @vanjatorp 🙌 - Thanks for your contribution! FeedbackTip You can refer to README.md for additional guidance.
Happy Coding! 🚀 |
|
Aloha @vanjatorp 🙌 - Thanks for your contribution! FeedbackTip You can refer to README.md for additional guidance.
Happy Coding! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Updated my git username with the new updated one in my previous contributions.
Pull request checklist
meta.jsonfile.<github_username>-<art_name>without the <>.index.htmlandstyles.css.index.htmlstyles.cssmeta.jsonwith:githubHandle: being your unique github user name,artName: name of your animationNot normally needed
Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section
What to expect