♻️ refactor(exceptions): zero-based review of exception hierarchy before 1.0.0#421
Merged
Conversation
…ore 1.0.0 (#336) - Remove table_name backward-compat aliases from RateLimiterUnavailable and InfrastructureNotFoundError - Rename StackCreationError → StackOperationError (no alias) - Reparent StackAlreadyExistsError as direct InfrastructureError subclass - Add LeaseExpiredError(RateLimitError) replacing RuntimeError in leases - Add NamespaceStateError(InfrastructureError) for namespace state conflicts - Convert namespace ValueError raises to ValidationError/NamespaceStateError - Update __init__.py exports, CLI catch sites, docs, and CLAUDE.md - Add scoped .claude/rules/exceptions.md for ongoing enforcement - Add comprehensive hierarchy tests (62 exception tests, 2603 unit total) Closes #336 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…in stack_manager Cover 5 missing lines in stack_manager.py (lines 94, 368, 572, 584, 611) to satisfy diff-cover 100% requirement. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sodre
added
api-design
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 92.19% 92.38% +0.19%
==========================================
Files 37 37
Lines 7842 7854 +12
==========================================
+ Hits 7230 7256 +26
+ Misses 612 598 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RateLimiterUnavailable is under InfrastructureError, not RateLimitError. Update docstring to reflect actual subclasses. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table_namealiases fromRateLimiterUnavailableandInfrastructureNotFoundErrorStackCreationErrortoStackOperationError(covers create, update, delete, and deploy)StackAlreadyExistsErroras directInfrastructureErrorsubclassLeaseExpiredError(RateLimitError)replacingRuntimeErrorin leasesNamespaceStateError(InfrastructureError)for namespace state conflictsValueErrorraises toValidationError/NamespaceStateError.claude/rules/exceptions.mdfor ongoing enforcementTest plan
Closes #336
🤖 Generated with Claude Code