Update C# build & build instructions #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Jan 30, 2025
.github/workflows/ci.yml
Outdated
| build_flags: ${{ runner.os == 'Windows' && '/t:BuildDist' || 'srcs' }} | ||
|
|
||
| - name: Publish C# NuGet Packages on ${{ matrix.os }} | ||
| timeout-minutes: 30 |
There was a problem hiding this comment.
Should we make this more like 5 mins?
.github/workflows/ci.yml
Outdated
Comment on lines
74
to
75
| run: dotnet msbuild ice.proj /t:Publish | ||
| if: runner.os != 'Windows' |
There was a problem hiding this comment.
Suggested change
| run: dotnet msbuild ice.proj /t:Publish | |
| if: runner.os != 'Windows' | |
| run: ${{ runner.os == 'Windows' && 'msbuild' || 'dotnet msbuild' }} ice.proj /t:Publish |
| You can build from the command-line or with Visual Studio 2022 for Windows. | ||
|
|
||
| ### Building the demos using NuGet packages | ||
| ### Building the demos |
There was a problem hiding this comment.
Should we mention that a local source build is currently required?
bernardnormier
approved these changes
Jan 30, 2025
csharp/README.md
Outdated
|
|
||
| The demos are configured to use the Ice NuGet packages. These packages are automatically | ||
| downloaded from nuget.org during the build. | ||
| For building the demos from the `main` branch you need to first install the .NET Ice NuGet packages, see the next |
There was a problem hiding this comment.
I would remove the entire sentence.
csharp/README.md
Outdated
| ```shell | ||
| dotnet restore "C# NET demos.sln" | ||
| dotnet msbuild "C# NET demos.sln" | ||
| dotnet build "C# NET demos.sln" |
There was a problem hiding this comment.
dotnet build is not sufficient?
csharp/README.md
Outdated
| ```shell | ||
| dotnet msbuild /p:IceHome=<Ice dist path> /t:NetInstallLocalPackages msbuild/ice.proj | ||
| ``` | ||
| Refer to the C# build instructions for creating and publishing the NuGet packages from a source build: |
There was a problem hiding this comment.
I would remove this section and take inspiration from https://github.com/icerpc/icerpc-csharp/blob/main/examples/README.md
There was a problem hiding this comment.
Removed, would improve the README in a follow up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades C# build & build instructions. It depends on zeroc-ice/ice#3451