Update C++ Windows build to use Publish target from ice #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Feb 3, 2025
| timeout-minutes: 5 | ||
| working-directory: ice/csharp/msbuild | ||
| run: ${{ runner.os == 'Windows' && 'msbuild' || 'dotnet msbuild' }} ice.proj /t:Publish | ||
| run: dotnet msbuild ice.proj /t:Publish |
There was a problem hiding this comment.
We can use dotnet msbuild in all platforms for C# builds.
pepone
commented
Feb 3, 2025
|
|
||
| <!-- Download nuget.exe if not present --> | ||
| <Target Name="GetNuget" Condition="!Exists('$(NugetExe)')"> | ||
| <Exec Command="powershell -ExecutionPolicy ByPass -Command "[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12;(New-Object Net.WebClient).DownloadFile('$(NugetURL)', '$(NugetExe)')""/> |
There was a problem hiding this comment.
We can remove this file if we switch to CMake. is a helper project to build all the demos.
externl
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to #3479 to use the new Publish target.