Greeter cleanup #254
Merged
Greeter cleanup #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
InsertCreativityHere,
externl and
pepone
Closed
pepone
approved these changes
Feb 4, 2025
externl
approved these changes
Feb 4, 2025
InsertCreativityHere
approved these changes
Feb 4, 2025
| This demo shows how to call and implement a canonical Greeter application using Ice. | ||
| # Greeter | ||
|
|
||
| The Greeter demo illustrates how to send a request and wait for the response. |
There was a problem hiding this comment.
I think 'this' was more clear. Saying 'the greeter demo' sounds like you're talking about some other demo,
but we're talking about this demo.
If you agree, here's a thing to save you some time:
Suggested change
| The Greeter demo illustrates how to send a request and wait for the response. | |
| This Greeter demo illustrates how to send a request and wait for the response. |
There was a problem hiding this comment.
I prefer "The Greeter demo". "This demo" when there is no qualification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is various bug fixes / cleanups of the new Greeter demo.
It also updates the MATLAB Greeter README to no longer rely on the top-level build.m script.