Merge greeterAsync into greeter (C++) #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
InsertCreativityHere,
externl and
pepone
externl
approved these changes
Feb 4, 2025
bernardnormier
commented
Feb 4, 2025
|
|
||
| // Start dispatching requests. | ||
| adapter->activate(); | ||
| cout << "Listening on port 4061..." << endl; |
There was a problem hiding this comment.
This is new too: I find it clearer when the server outputs something at startup.
pepone
approved these changes
Feb 4, 2025
Yes, I think we should. Joe is taking care of it. |
InsertCreativityHere
approved these changes
Feb 4, 2025
Co-authored-by: Austin Henriksen <[email protected]>
Co-authored-by: Austin Henriksen <[email protected]>
Co-authored-by: Austin Henriksen <[email protected]>
Co-authored-by: Austin Henriksen <[email protected]>
Co-authored-by: Austin Henriksen <[email protected]>
externl
added a commit
to externl/ice-demos
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges greeterAsync into greeter. I only update the new cmake build system for greeter.