Skip to content

Conversation

@externl
Copy link
Member

@externl externl commented Feb 4, 2025

This PR adds CMakeLists.txt to the cpp/Ice demos that we plan on keeping.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 24 out of 39 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • .vscode/settings.json: Language not supported
  • cpp/Ice/async/CMakeLists.txt: Language not supported
  • cpp/Ice/bidir/CMakeLists.txt: Language not supported
  • cpp/Ice/callback/CMakeLists.txt: Language not supported
  • cpp/Ice/context/CMakeLists.txt: Language not supported
  • cpp/Ice/interceptor/AuthenticatorI.cpp: Language not supported
  • cpp/Ice/interceptor/CMakeLists.txt: Language not supported
  • cpp/Ice/interceptor/InterceptorI.h: Language not supported
  • cpp/Ice/interceptor/ThermostatI.h: Language not supported
  • cpp/Ice/interleaved/CMakeLists.txt: Language not supported
  • cpp/Ice/invoke/CMakeLists.txt: Language not supported
  • cpp/Ice/latency/CMakeLists.txt: Language not supported
  • cpp/Ice/bidir/README.md: Evaluated as low risk
  • cpp/Ice/greeterAsync/README.md: Evaluated as low risk
  • cpp/Ice/greeter/README.md: Evaluated as low risk

Copy link
Member

@InsertCreativityHere InsertCreativityHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't look at the README's because it looks like they're just cookie-cutters of each other.

But I checked all the other files, and everything looks fine to me!

@externl externl merged commit 955cb0c into zeroc-ice:main Feb 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants