Php greeter #259
Merged
Php greeter #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Feb 4, 2025
bernardnormier
commented
Feb 4, 2025
| // Send a request to the remote object and get the response. | ||
| $greeting = $greeter->greet(get_current_user()); | ||
|
|
||
| echo "$greeting\n"; |
There was a problem hiding this comment.
I assume that's the correct syntax. Please check.
There was a problem hiding this comment.
Yes it is.
php test.php
Hello, Jose
jose@studio rpm % cat test.php
<?php
$greeting = "Hello, Jose";
echo "$greeting\n";
| require_once 'Ice.php'; | ||
| require_once 'Greeter.php'; | ||
|
|
||
| // Create an Ice communicator to initialize the Ice runtime. This communicator is destroyed automatically at the end of |
There was a problem hiding this comment.
I verified the communicator is indeed destroyed even though there is no call to ->destroy
There was a problem hiding this comment.
pepone
approved these changes
Feb 5, 2025
| require_once 'Ice.php'; | ||
| require_once 'Greeter.php'; | ||
|
|
||
| // Create an Ice communicator to initialize the Ice runtime. This communicator is destroyed automatically at the end of |
There was a problem hiding this comment.
| // Send a request to the remote object and get the response. | ||
| $greeting = $greeter->greet(get_current_user()); | ||
|
|
||
| echo "$greeting\n"; |
There was a problem hiding this comment.
Yes it is.
php test.php
Hello, Jose
jose@studio rpm % cat test.php
<?php
$greeting = "Hello, Jose";
echo "$greeting\n";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to add a second HTML version of this demo. Or maybe make "secure" HTML.