New IceBox greeter demo (C++) #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 6, 2025
| @@ -0,0 +1,18 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
There was a problem hiding this comment.
Greeter.ice, Chatbot.h and Chatbot.cpp are exact copies of the files in Ice/greeter.
|
|
||
| using namespace std; | ||
|
|
||
| int |
There was a problem hiding this comment.
A simplified version of the Ice/greeter client. You can also use the Greeter client if you like.
|
|
||
| #include <IceBox/IceBox.h> | ||
|
|
||
| namespace GreeterServer |
There was a problem hiding this comment.
In the same namespace as Chatbot (GreeterServer).
externl
approved these changes
Feb 7, 2025
|
|
||
| void | ||
| GreeterServer::GreeterService::start( | ||
| const string& name, |
There was a problem hiding this comment.
I think name is also unused here. I need to enable build warnings tomorrow.
pepone
approved these changes
Feb 7, 2025
| **Linux:** | ||
|
|
||
| ```shell | ||
| LD_LIBRARY_PATH=./build icebox --IceBox.Service.Greeter="GreeterService:create --Ice.Trace.Dispatch" |
There was a problem hiding this comment.
Should this be --Ice.Trace.Dispatch=1?
There was a problem hiding this comment.
=1 is the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new IceBox/greeter demo, derived from Ice/greeter and IceBox/hello.