Skip to content

Conversation

@bernardnormier
Copy link
Member

No description provided.

Copy link
Member

@pepone pepone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think this demo should use the API instead. And use the SslClientAuthenticationOptions and SslServerAuthenticationOptions to configure SSL.


// Create an Ice communicator to initialize the Ice runtime. The communicator gets its properties from file
// "config.client".
using Ice.Communicator communicator = Ice.Util.initialize(ref args, "config.client");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead show case the new APIs using SslClientAuthenticationOptions?

IceSSL properties are mostly for compatibility, but the native APIs should be preferred.

@bernardnormier
Copy link
Member Author

Looks good, but I think this demo should use the API instead. And use the SslClientAuthenticationOptions and SslServerAuthenticationOptions to configure SSL.

I agree. Please go ahead and fix it.

@bernardnormier bernardnormier merged commit 30447cf into zeroc-ice:main Feb 7, 2025
7 checks passed
@bernardnormier bernardnormier deleted the cs-secure branch June 18, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants