Fix namespace in demo servers (C++ and C#) #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
commented
Feb 10, 2025
| #include <sstream> | ||
|
|
||
| using namespace std; | ||
| using namespace ConfigServer; |
There was a problem hiding this comment.
Also removed using namespace to make it clearer what comes from the Server namespace.
| @@ -1,15 +1,13 @@ | |||
| // Copyright (c) ZeroC, Inc. | |||
|
|
|||
| using GreeterServer; | |||
There was a problem hiding this comment.
Same as in C++: it's clearer without this using.
|
|
||
| /// A Chatbot is an Ice servant that implements Slice interface Greeter. | ||
| class ChatBot: Greeter { | ||
| class Chatbot: Greeter { |
pepone
approved these changes
Feb 11, 2025
externl
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demo updates the new demos (Greeter, Config) to use namespace Server for the server implementation.
It's consistent with the C# naming conventions and works fine with Ice since Ice doesn't define a Server class.