Update filesystem demo in C# #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
requested review from
InsertCreativityHere,
externl and
pepone
bernardnormier
commented
Feb 11, 2025
| #include "Memory.h" | ||
|
|
||
| using namespace std; | ||
| using namespace Memory; |
There was a problem hiding this comment.
Switch to namespace Server and no using namespace like in other C++ demos.
| private readonly string _name; | ||
| private readonly List<Filesystem.NodePrx> _contents = new(); | ||
|
|
||
| /// <inheritdoc/> |
There was a problem hiding this comment.
There is currently nothing to inherit currently as slice2cs neglects to generate doc-comments for server-side interfaces / classes.
| private readonly List<Filesystem.NodePrx> _contents = new(); | ||
|
|
||
| /// <inheritdoc/> | ||
| public override string Name(Ice.Current current) => _name; |
There was a problem hiding this comment.
Unlike the C++ version, we can't define a MNode and reuse it. That's because XxxDisp_ is a class.
pepone
approved these changes
Feb 12, 2025
externl
approved these changes
Feb 12, 2025
InsertCreativityHere
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now in sync with the C++ version.