Use Linux and macOS nightly repos #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Feb 26, 2025
| echo "deb [signed-by=/etc/apt/keyrings/zeroc-nightly.gpg] https://download.zeroc.com/nexus/repository/ubuntu24.04-nightly nightly main" | sudo tee /etc/apt/sources.list.d/zeroc-nightly.list | ||
| sudo apt-get update | ||
| sudo apt-get install zeroc-ice-all-dev |
There was a problem hiding this comment.
don't we need to pass -y for non interactive mode?
There was a problem hiding this comment.
I think they set some env variables so you don't need do but I think it's better to add it.
pepone
approved these changes
Feb 27, 2025
| dependencies: [.product(name: "Ice", package: "ice-swift")], | ||
| exclude: ["slice-plugin.json"], | ||
| plugins: [.plugin(name: "CompileSlice", package: "ice")] | ||
| plugins: [.plugin(name: "CompileSlice", package: "ice-swift")] |
There was a problem hiding this comment.
Can't we use 'ice' for the package name?
There was a problem hiding this comment.
Swift says that .package(name:url:branch) is deprecated and just .package(url:branch) should be used. it picks the package name from the repo name. This will change to ice once we move to the ice repo for release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Linux and macOS builds to use our nightly brew and apt packaging.
For now I've disable the Java build as we want to fix this demos anyway and they still rely on the nightly.