Update C# project to use new C# NuGet packaging #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardnormier
approved these changes
Mar 3, 2025
| *.runtimeconfig.dev.json | ||
|
|
||
| **/generated/** | ||
| *.dll |
There was a problem hiding this comment.
I don't understand this addition.
We should git-ignore the build directories where all these files are copied to.
There was a problem hiding this comment.
This is for the old projects that use the project dir as the output dir:
Untracked files:
(use "git add <file>..." to include in what will be committed)
Glacier2/callback/Glacier2.dll
Glacier2/callback/Ice.dll
Glacier2/callback/client.dll
Glacier2/callback/server.dll
Ice/interceptor/Ice.dll
Ice/interceptor/client.dll
Ice/interceptor/server.dll
Ice/multicast/Ice.dll
Ice/multicast/client.dll
Ice/multicast/server.dll
Ice/optional/Ice.dll
Ice/optional/client.dll
Ice/optional/server.dll
Ice/properties/Ice.dll
Ice/properties/client.dll
Ice/properties/server.dll
Ice/session/Ice.dll
Ice/session/client.dll
Ice/session/server.dll
IceBox/hello/Ice.dll
IceBox/hello/client.dll
IceBox/hello/helloservice.dll
IceDiscovery/hello/Ice.dll
IceDiscovery/hello/IceDiscovery.dll
IceDiscovery/hello/client.dll
IceDiscovery/hello/server.dll
IceDiscovery/replication/Ice.dll
IceDiscovery/replication/IceDiscovery.dll
IceDiscovery/replication/client.dll
IceDiscovery/replication/server.dll
IceGrid/icebox/Ice.dll
IceGrid/icebox/client.dll
IceGrid/icebox/helloservice.dll
IceGrid/simple/Glacier2.dll
IceGrid/simple/Ice.dll
IceGrid/simple/IceGrid.dll
IceGrid/simple/client.dll
IceGrid/simple/server.dll
IceStorm/clock/Ice.dll
IceStorm/clock/IceStorm.dll
IceStorm/clock/publisher.dll
IceStorm/clock/subscriber.dll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades C# build to use new NuGet packages from zeroc-ice/ice#3615
Expect the build to fail until the other PR is merge and the new packages are deployed.