Improvements to C++ README and CMakeLists.txt #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
commented
Mar 3, 2025
| "${workspaceFolder}/cpp/IceStorm/replicated2", | ||
| ] | ||
| ], | ||
| "cmake.configureSettings": { |
There was a problem hiding this comment.
This just tells the Ice CMake file to print its configuration during configuration. It will appear in the Visual Studio CMake console.
bernardnormier
approved these changes
Mar 3, 2025
| - [C++ Demos](#c-demos) | ||
| - [Overview](#overview) | ||
| - [macOS Prerequisites](#macos-prerequisites) | ||
| - [Ubuntu Prerequisites](#ubuntu-prerequisites) |
There was a problem hiding this comment.
It sounds like we're dropping all other Linux distributions. You should be able to build the demos on RHEL!
There was a problem hiding this comment.
Yes I still need to add RHEL
pepone
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the C++ CMakeList.txt files to copy the
TARGET_RUNTIME_DLLSpost build. It also cleans up the C++ README.