New IceGrid/LocatorDiscovery demo (C#) #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Mar 3, 2025
pepone
approved these changes
Mar 3, 2025
| // Slice module VisitorCenter in Greeter.ice maps to C# namespace VisitorCenter. | ||
| using VisitorCenter; | ||
|
|
||
| // Configure the communicator to load the LocatorDiscovery plugin during initialization. We don't configure a locator |
There was a problem hiding this comment.
Maybe we can mention the locator discovery plug-in is used to configure the communicator locator, instead of mentioning what we don't do.
There was a problem hiding this comment.
You're right, I updated the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new IceGrid/LocatorDiscovery demo (C#).
This demo provides only a client. Everything else comes from Greeter.
Alternatively:
we could copy everything else from Greeter (except Client) in here ... but this is a lot of duplication, and the user may not see immediately what's different
add a second client in IceGrid/Greeter - the LocatorDiscoveryClient. Downside: this makes Greeter more complicated