Add IceDiscovery/Replication demo in C# #339
Conversation
There was a problem hiding this comment.
PR Overview
This PR adds an IceDiscovery/Replication demo implemented in C#. It introduces new server and client applications along with a Chatbot servant and updates the README with build and run instructions.
Reviewed Changes
| File | Description |
|---|---|
| csharp/IceDiscovery/Replication/Server/Program.cs | Adds the server setup with an object adapter and graceful shutdown logic. |
| csharp/IceDiscovery/Replication/Client/Program.cs | Implements the client that initializes the communicator and sends a greeting request. |
| csharp/IceDiscovery/Replication/Server/Chatbot.cs | Introduces the Chatbot servant implementing the Greeter interface. |
| csharp/IceDiscovery/Replication/README.md | Provides instructions for building and running the demo. |
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
csharp/IceDiscovery/Replication/Server/Program.cs:31
- Typo in comment: 'serer' should be corrected to 'server'.
// Register the Chatbot servant with the adapter. Here, well-known object "greeter" is replicated across all serer instances.
| // information, also known as a well-known proxy. It's resolved by the default locator installed by the IceDiscovery | ||
| // plugin. | ||
| GreeterPrx greeter = GreeterPrxHelper.createProxy(communicator, "greeter"); | ||
|
|
There was a problem hiding this comment.
One issue with these IceDiscovery demos is that we assume the locator was set at this point. If I recall correctly the plug-in does this in the background, and there is no API to wait for it.
There was a problem hiding this comment.
Doesn't it do it during plugin init when we initialize the communicator?
There was a problem hiding this comment.
I am not aware of any issue or bug with the IceDiscovery plugin initialization.
3 participants
No description provided.