CI Cleanup #346
Merged
CI Cleanup #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR cleans up the CI workflow configuration.
- Removed deprecated build flags from the matrix.
- Updated action references and working directory paths for various demo builds.
Reviewed Changes
| File | Description |
|---|---|
| .github/workflows/ci.yml | Removed unused build flags, updated action references, and changed working directories for demo builds. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:27
- Ensure that removing the 'ice_build_flags' from the matrix does not unintentionally affect build configurations on the specified OS entries.
ice_build_flags: srcs
.github/workflows/ci.yml:45
- Verify that the new working directory 'cpp' correctly reflects the actual path for the C++ demos, as it replaces the previous 'ice-demos/cpp' path.
working-directory: cpp
pepone
reviewed
Mar 7, 2025
| # We reuse the setup-dependencies action from the Ice repository | ||
| - name: Setup Ice Build Dependencies | ||
| uses: ./ice/.github/actions/setup-dependencies | ||
| uses: zeroc-ice/ice/.github/actions/setup-dependencies@main |
There was a problem hiding this comment.
Didn't you remove the checkout of this repo? So it uses directly from main branch with this syntax?
pepone
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.