Turn on AnalysisMode=all in C# #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR enables AnalysisMode=all in C# and updates several files to comply with stricter analysis requirements. The changes include:
- Changing GreeterService from internal to public in two separate locations.
- Updating Program.cs to use CultureInfo.CurrentCulture when formatting the timestamp.
- Replacing manual null checks with ArgumentNullException.ThrowIfNull in two SimpleWakeUpService.cs files for a more modern and concise approach.
Reviewed Changes
| File | Description |
|---|---|
| csharp/IceBox/Greeter/Service/GreeterService.cs | Changed accessibility from internal to public |
| csharp/IceGrid/IceBox/Service/GreeterService.cs | Changed accessibility from internal to public |
| csharp/IceStorm/Weather/Sensor/Program.cs | Introduced CultureInfo usage for timestamp formatting |
| csharp/Ice/Callback/Server/SimpleWakeUpService.cs | Replaced null check with ArgumentNullException.ThrowIfNull |
| csharp/Glacier2/Callback/Server/SimpleWakeUpService.cs | Replaced null check with ArgumentNullException.ThrowIfNull |
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
bernardnormier
commented
Mar 9, 2025
| dotnet_code_quality_unused_parameters = all:suggestion | ||
|
|
||
| # Diagnostic preferences | ||
| dotnet_diagnostic.CA5394.severity = none # Do not use insecure randomness |
There was a problem hiding this comment.
Otherwise, can't use the pseudo-random generator System.Random.
There was a problem hiding this comment.
Instead we should be using RandomNumberGenerator.GetInt32 like we do in IceRPC.
There was a problem hiding this comment.
Will fix in a follow-up PR.
| <ImplicitUsings>true</ImplicitUsings> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <!-- <AnalysisMode>All</AnalysisMode> --> | ||
| <ImplicitUsings>enable</ImplicitUsings> |
There was a problem hiding this comment.
This is / should be specified in all .csproj files.
pepone
approved these changes
Mar 9, 2025
externl
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.