Update demos to use new GitHub nightly repositories #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates all Swift demo packages and the CI action to use the new GitHub-hosted nightly Ice repositories instead of the old Zeroc Nexus feeds.
- Switched Package.swift dependencies and package names from
ice-swifttoice-swift-nightly - Updated the brew tap URL in the install-nightly-ice action to point at the GitHub Homebrew tap
- Adjusted plugin references to use the nightly package name
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swift/IceStorm/weather/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/IceGrid/query/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/IceGrid/locatorDiscovery/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/IceGrid/greeter/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/IceDiscovery/replication/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/IceDiscovery/greeter/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/optional/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/middleware/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/invocationTimeout/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/greeter/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/forwarder/Package.swift | Point to ice-swift-nightly and update products |
| swift/Ice/filesystem/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/customError/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/context/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/config/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/callback/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Ice/bidir/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Glacier2/greeter/Package.swift | Point to ice-swift-nightly and update products/plugins |
| swift/Glacier2/callback/Package.swift | Point to ice-swift-nightly and update products/plugins |
| .github/actions/install-nightly-ice/action.yml | Updated brew tap URL to GitHub homebrew-nightly |
Comments suppressed due to low confidence (1)
swift/IceStorm/weather/Package.swift:10
- [nitpick] The nightly repository URL and package name are repeated across many Package.swift files. Consider centralizing this dependency configuration in a shared manifest or workspace-level setting to reduce duplication and simplify future updates.
.package(url: "https://github.com/zeroc-ice/ice-swift-nightly.git", branch: "main"),
externl
approved these changes
Jun 11, 2025
| shell: bash | ||
| run: | | ||
| brew tap zeroc-ice/nightly https://download.zeroc.com/nexus/repository/nightly/homebrew-nightly.git | ||
| brew tap zeroc-ice/nightly https://github.com/zeroc-ice/homebrew-nightly.git |
There was a problem hiding this comment.
We can just remove this whole line now. Install cmd will add the tap automatically.
pepone
commented
Jun 11, 2025
externl
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.