Skip to content

Conversation

@pepone
Copy link
Member

@pepone pepone commented Sep 23, 2025

We already run eslint with each demo build, because the config is per demo. This PR just adds a workflow to check format with prettier like we do for ice repository.

@pepone pepone requested review from Copilot and externl September 23, 2025 15:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a GitHub Actions workflow to enforce JavaScript/TypeScript code formatting consistency using Prettier across the JavaScript demo applications, complementing the existing ESLint configuration that runs with each demo build.

  • Adds a new GitHub Actions workflow for JavaScript formatting checks
  • Applies Prettier formatting fixes to existing JavaScript demo configuration files
  • Ensures consistent code style across all JavaScript demos in the repository

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

File Description
.github/workflows/javascript.yml New GitHub Actions workflow to run Prettier formatting checks on JavaScript code
js/*/tsconfig.json Removes trailing commas from TypeScript configuration files to match Prettier formatting
js/*/eslint.config.js Adds trailing commas to ESLint configuration arrays to match Prettier formatting

@pepone pepone merged commit 45d061d into zeroc-ice:main Sep 23, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants