Skip to content

Conversation

@bernardnormier
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the initialization pattern in PHP demo applications for the Ice framework by correcting how command-line arguments are passed to the initialize and createProperties functions.

Key changes:

  • Updates createProperties() calls to accept $argv parameter for proper command-line argument parsing
  • Modifies Ice\initialize() calls to only accept the initialization data parameter, removing duplicate $argv argument

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
php/IceGrid/locatorDiscovery/Client.php Updated Ice initialization to pass argv to createProperties and remove duplicate argv from initialize call
php/IceDiscovery/greeter/Client.php Updated Ice initialization to pass argv to createProperties and remove duplicate argv from initialize call

@bernardnormier bernardnormier merged commit 497b1cd into zeroc-ice:main Sep 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants