Skip to content

Conversation

@bernardnormier
Copy link
Member

Uses {...} instead of (...) to call Node and Topic constructors.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies a cosmetic update to DataStorm constructor calls by replacing parentheses (...) with curly braces {...} for uniform initialization syntax. Additionally, it includes a minor variable renaming change.

  • Standardizes constructor syntax by using brace initialization for Node and Topic constructors
  • Updates variable naming from ich to communicatorHolder for better clarity
  • Updates Node constructor calls to use the renamed variable

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cpp/DataStorm/stock/Writer.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/stock/Reader.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/sampleFilter/Writer.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/sampleFilter/Reader.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/node/Writer.cpp Updates constructors and renames variable from ich to communicatorHolder
cpp/DataStorm/node/Reader.cpp Updates constructors and renames variable from ich to communicatorHolder
cpp/DataStorm/minimal/Writer.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/minimal/Reader.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/keyFilter/Writer.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/keyFilter/Reader.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/clock/Writer.cpp Updates Node and Topic constructors to use brace initialization
cpp/DataStorm/clock/Reader.cpp Updates Node and Topic constructors to use brace initialization

@bernardnormier bernardnormier merged commit 9c12927 into zeroc-ice:main Sep 26, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants