Fix Java Ice/customError build failure #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Sep 26, 2025
There was a problem hiding this comment.
Executable bit was missing.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a build failure in the Java Ice/customError demo by updating the initialization pattern to use the newer Ice framework API. The key change involves properly setting up properties and adjusting the communicator initialization call.
Key changes:
- Added proper Properties import and initialization
- Updated the Util.initialize() call signature to use the newer API pattern
java/Ice/customError/client/src/main/java/com/example/ice/customerror/client/Client.java
Outdated
Show resolved
Hide resolved
bernardnormier
approved these changes
Sep 26, 2025
| // Java applications that unmarshal classes or exceptions, when the classes/exceptions or their enclosing | ||
| // module(s) are remapped using java:identifier, like in this demo. | ||
| var initData = new InitializationData(); | ||
| initData.properties = new Properties(args); |
There was a problem hiding this comment.
I would move the properties assignment after the sliceLoader assignment, because of the comment above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a build failure in Ice/customError related to initialize updates.