-
Couldn't load subscription status.
- Fork 216
Java glacier2 callback #624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new Java Glacier2 callback demo that demonstrates how to establish a session with a Glacier2 router and implement callbacks through the router.
- Implementation of a complete Glacier2 callback demo with client-server architecture
- Client establishes a bidirectional connection through Glacier2 router for callbacks
- Server provides wake-up service that calls back to the client's alarm clock implementation
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| java/Glacier2/callback/slice/AlarmClock.ice | Defines Slice interfaces for AlarmClock callback and WakeUpService |
| java/Glacier2/callback/settings.gradle.kts | Gradle settings configuring multi-project build with client/server modules |
| java/Glacier2/callback/server/src/main/java/com/example/glacier2/callback/server/SimpleWakeUpService.java | Server-side service implementation that schedules and executes alarm callbacks |
| java/Glacier2/callback/server/src/main/java/com/example/glacier2/callback/server/Server.java | Main server application with Ice communicator and object adapter setup |
| java/Glacier2/callback/server/build.gradle.kts | Server module build configuration with Slice compilation |
| java/Glacier2/callback/gradlew.bat | Gradle wrapper script for Windows |
| java/Glacier2/callback/gradlew | Gradle wrapper script for Unix-like systems |
| java/Glacier2/callback/gradle/wrapper/gradle-wrapper.properties | Gradle wrapper configuration |
| java/Glacier2/callback/config.glacier2 | Glacier2 router configuration file |
| java/Glacier2/callback/client/src/main/java/com/example/glacier2/callback/client/MockAlarmClock.java | Client-side AlarmClock implementation for callback handling |
| java/Glacier2/callback/client/src/main/java/com/example/glacier2/callback/client/Client.java | Main client application with Glacier2 session management |
| java/Glacier2/callback/client/build.gradle.kts | Client module build configuration |
| java/Glacier2/callback/README.md | Documentation explaining the demo architecture and usage |
| java/Glacier2/callback/.gitignore | Git ignore file for build artifacts |
java/Glacier2/callback/README.md
Outdated
|
|
||
| > [!TIP] | ||
| > You can also start the Glacier2 router before the server. The order does not matter: the server is identical to the | ||
| > server provided in the [Ice Greeter][1] demo and does not depend on Glacier2. |
Copilot
AI
Sep 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reference to 'Ice Greeter' demo is incorrect. Based on the context, this should reference the 'Ice Callback' demo since this Glacier2 demo is similar to the Ice Callback demo mentioned at the beginning.
| > server provided in the [Ice Greeter][1] demo and does not depend on Glacier2. | |
| > server provided in the [Ice Callback][1] demo and does not depend on Glacier2. |
| [1]: ../callback | ||
| [2]: ../bidir |
Copilot
AI
Sep 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link references are inconsistent with their usage in the document. Reference [1] is used for both 'Ice Callback' and 'Ice Greeter', but they point to different demos. The reference on line 46 should use [2] for 'Ice Greeter' or the text should be corrected to reference 'Ice Callback'.
| } catch (InterruptedException | ExecutionException ex) { | ||
| System.err.println(ex); | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra blank line
No description provided.