Remove/fix variant comments #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes outdated comments about "variant" implementations and corrects a comment in the Swift AMD implementation. The changes clean up documentation that was misleading or redundant across multiple Chatbot implementations in different Ice framework demos.
- Removes "This variant is the synchronous implementation" comments from C# and Python Chatbot classes
- Corrects the Swift AMD comment to properly describe Asynchronous Method Dispatch
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| swift/Ice/Greeter/Sources/ServerAMD/Chatbot.swift | Corrected comment to properly describe AMD implementation |
| python/Ice/config/server/chatbot.py | Removed redundant "synchronous variant" comment |
| Multiple csharp/*/Chatbot.cs files | Removed outdated "synchronous variant" comments from various demo implementations |
pepone
approved these changes
Oct 7, 2025
| struct Chatbot: Greeter { | ||
| // Implements the method greet from the Greeter protocol generated by the Slice compiler. | ||
| // This version uses the Asynchronous Method Dispatch (AMD) variant. It uses the same Slice file as synchronous | ||
| // This version uses Asynchronous Method Dispatch (AMD). It uses the same Slice file as the synchronous |
There was a problem hiding this comment.
What about "the same Slice definitions as ..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.