Update DataStorm CtrlCHandler comments #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation comments for the Ice::CtrlCHandler across multiple DataStorm demo applications to provide clearer and more descriptive explanations of its purpose and usage requirements.
- Updated comment format from a single line to a multi-line format for better readability
- Enhanced explanation to describe CtrlCHandler as a helper class that handles Ctrl+C and similar signals
- Maintained the important timing requirement that it must be constructed before creating DataStorm nodes or starting threads
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/DataStorm/stock/Writer.cpp | Updated CtrlCHandler comment with enhanced description |
| cpp/DataStorm/stock/Reader.cpp | Updated CtrlCHandler comment with enhanced description |
| cpp/DataStorm/node/Writer.cpp | Updated CtrlCHandler comment with enhanced description |
| cpp/DataStorm/node/Reader.cpp | Updated CtrlCHandler comment with enhanced description |
| cpp/DataStorm/clock/Writer.cpp | Updated CtrlCHandler comment with enhanced description |
| cpp/DataStorm/clock/Reader.cpp | Updated CtrlCHandler comment with enhanced description |
bernardnormier
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.